Retain tiles just outside the viewport a bit longer. #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes #3465, which is being reviewed separately. We can either wait until that's reviewed or close that and land both commits in this PR. Pending picture caching try: |
Expand the size of the needed region that active tiles exist over. This means that as tiles get scrolled just in / out of the screen we retain them for a bit longer. Since we only support a single dirty rect (for now), this is helpful for avoiding the case of creating a large dirty rect when something in the middle of the screen is animating while scrolling. In future, once multiple dirty rects are supported, it will be far less important to retain tiles outside the viewport. Also fix a subtle bug with the descriptor dependencies where clipped out primitives would invalidate the tile due to changing the length of the descriptor needed_rects array.
|
@bors-servo r=bholley (via email) |
|
📌 Commit 63a331d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 4, 2019
Retain tiles just outside the viewport a bit longer. Expand the size of the needed region that active tiles exist over. This means that as tiles get scrolled just in / out of the screen we retain them for a bit longer. Since we only support a single dirty rect (for now), this is helpful for avoiding the case of creating a large dirty rect when something in the middle of the screen is animating while scrolling. In future, once multiple dirty rects are supported, it will be far less important to retain tiles outside the viewport. Also fix a subtle bug with the descriptor dependencies where clipped out primitives would invalidate the tile due to changing the length of the descriptor needed_rects array. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3467) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 4, 2019
…3e4d157d4478 (WR PR #3467). r=kats servo/webrender#3467 Differential Revision: https://phabricator.services.mozilla.com/D15722 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Jan 5, 2019
…3e4d157d4478 (WR PR #3467). r=kats servo/webrender#3467 Differential Revision: https://phabricator.services.mozilla.com/D15722
kvark
reviewed
Jan 8, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gw3583)
webrender/src/picture.rs, line 506 at r1 (raw file):
let needed_device_rect = needed_device_rect.inflate( 0.0, 3.0 * TILE_SIZE_HEIGHT as f32,
would be good to move it out as a const, unless this is strictly temporary
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…3e4d157d4478 (WR PR #3467). r=kats servo/webrender#3467 Differential Revision: https://phabricator.services.mozilla.com/D15722 UltraBlame original commit: 1b01f47f32c02a3335ee107c53ebf85306026875
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…3e4d157d4478 (WR PR #3467). r=kats servo/webrender#3467 Differential Revision: https://phabricator.services.mozilla.com/D15722 UltraBlame original commit: 1b01f47f32c02a3335ee107c53ebf85306026875
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…3e4d157d4478 (WR PR #3467). r=kats servo/webrender#3467 Differential Revision: https://phabricator.services.mozilla.com/D15722 UltraBlame original commit: 1b01f47f32c02a3335ee107c53ebf85306026875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the size of the needed region that active tiles exist
over. This means that as tiles get scrolled just in / out of
the screen we retain them for a bit longer.
Since we only support a single dirty rect (for now), this is
helpful for avoiding the case of creating a large dirty rect
when something in the middle of the screen is animating while
scrolling. In future, once multiple dirty rects are supported,
it will be far less important to retain tiles outside the
viewport.
Also fix a subtle bug with the descriptor dependencies where
clipped out primitives would invalidate the tile due to changing
the length of the descriptor needed_rects array.
This change is