Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init_texture() does not care format change on arm #661

Closed
sotaroikeda opened this issue Dec 22, 2016 · 1 comment
Closed

init_texture() does not care format change on arm #661

sotaroikeda opened this issue Dec 22, 2016 · 1 comment
Labels
type: bug

Comments

@sotaroikeda
Copy link
Contributor

On arm, ImageFormat::A8 uses GL_FORMAT_BGRA. Then init_texture() need to expand data like update_texture(). By it, debug_render's rendering seems to be broken on my nexus5X with quantum graphic branch.
https://bugzilla.mozilla.org/show_bug.cgi?id=1323612

device.rs defines the following, but it seems not used.

#[cfg(any(target_arch = "arm", target_arch = "aarch64"))]
const GL_FORMAT_A: gl::GLuint = gl::ALPHA;
@sotaroikeda sotaroikeda mentioned this issue Jan 24, 2017
Merged
bors-servo pushed a commit that referenced this issue Jan 27, 2017
Auto merge of #779 - sotaroikeda:Bug1325911-1, r=kvark
0ab4b60 
Expand data in init_texture() on arm like update_texture()

Fixes issue #661.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/779)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jan 27, 2017
Auto merge of #779 - sotaroikeda:Bug1325911-1, r=kvark
706d607 
Expand data in init_texture() on arm like update_texture()

Fixes issue #661.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/779)
<!-- Reviewable:end -->
@glennw
Copy link
Member

glennw commented Feb 7, 2017

This was fixed in #779.

@glennw glennw closed this as completed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @sotaroikeda @glennw