-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The backdrop component of a MixBlendMode composite is always white #838
Comments
My change didn't touch either the shader or the color, it only affected the clipping. |
Yes, so I don't have any idea why it would have caused this. But if I run it before and after your patch the behavior changes. Could something be clipped too much in an intermediate step? |
I tested it on master, and the inner square is black. |
You're right, I retested on master (512b4a1) and it works. The commit before that is failing. |
Sweet, thanks @rlhunt |
Right now the backdrop color used by ps_composite.fs.glsl is fixed to rgb(255, 255, 255). This breaks mix blend mode. Sadly the only test for mix-blend-mode in wrench passes with that.
I did a git bisect to find when this regressed and got 'Include the clipping rectangle of a stacking context into the clip stack', SHA: dacef46
You can test this by switching the mix-blend-mode of reftests/blend/multiply.yaml to difference. The inner square should be rgb(0,0,0) but it's rgb(255,0,255)
@kvark
The text was updated successfully, but these errors were encountered: