Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix local clip rect being applied in transform shader. #1760
Conversation
|
There is a gecko try run here, that has some failures. https://hg.mozilla.org/try/rev/2b2948c12b1d516c5d7bb49a07cd6b1d9ffd1d00 I think all the failures are intermittent, except for one permanent failure in R4 on I'll debug it tomorrow, unless @staktrace or @jrmuizel have any ideas about that failure? |
|
Hmmm, that same test is failing (in the same way) for me locally, without this patch applied (just running with current tip). So I think that means this is fine to merge - @staktrace ? |
|
I also verified that none of the items in that test are running through the transform shader path. |
|
@glennw Yeah this appears to be a pre-existing failure that cropped up sometime last night. I'm chasing down what caused it but it is unrelated to your patches so feel free to land your stuff. Bug 1403457 is tracking the failure if you're interested. |
|
@bors-servo r+ |
|
|
Fix local clip rect being applied in transform shader. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1760) <!-- Reviewable:end -->
|
|
glennw commentedSep 27, 2017
•
edited by larsbergstrom
This change is