New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix local clip rect being applied in transform shader. #1760
Conversation
There is a gecko try run here, that has some failures. https://hg.mozilla.org/try/rev/2b2948c12b1d516c5d7bb49a07cd6b1d9ffd1d00 I think all the failures are intermittent, except for one permanent failure in R4 on I'll debug it tomorrow, unless @staktrace or @jrmuizel have any ideas about that failure? |
Hmmm, that same test is failing (in the same way) for me locally, without this patch applied (just running with current tip). So I think that means this is fine to merge - @staktrace ? |
I also verified that none of the items in that test are running through the transform shader path. |
@glennw Yeah this appears to be a pre-existing failure that cropped up sometime last night. I'm chasing down what caused it but it is unrelated to your patches so feel free to land your stuff. Bug 1403457 is tracking the failure if you're interested. |
@bors-servo r+ |
📌 Commit 84a2959 has been approved by |
Fix local clip rect being applied in transform shader. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1760) <!-- Reviewable:end -->
☀️ Test successful - status-appveyor, status-travis |
This change is