Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local clip rect being applied in transform shader. #1760

Merged
merged 1 commit into from Sep 27, 2017

Conversation

glennw
Copy link
Member

@glennw glennw commented Sep 27, 2017

This change is Reviewable

@glennw
Copy link
Member Author

glennw commented Sep 27, 2017

r? @kvark

Fixes #1732.

This still needs a gecko try run. Passes the servo/wrench tests ok.

@glennw
Copy link
Member Author

glennw commented Sep 27, 2017

There is a gecko try run here, that has some failures.

https://hg.mozilla.org/try/rev/2b2948c12b1d516c5d7bb49a07cd6b1d9ffd1d00
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b2948c12b1d516c5d7bb49a07cd6b1d9ffd1d00

I think all the failures are intermittent, except for one permanent failure in R4 on layout/reftests/bugs/579323-1.html. I briefly looked at that test and there's no transform elements on it. Given that, I wouldn't expect this test to be affected (since it should be running through the non-transform shader path).

I'll debug it tomorrow, unless @staktrace or @jrmuizel have any ideas about that failure?

@glennw
Copy link
Member Author

glennw commented Sep 27, 2017

Hmmm, that same test is failing (in the same way) for me locally, without this patch applied (just running with current tip). So I think that means this is fine to merge - @staktrace ?

@glennw
Copy link
Member Author

glennw commented Sep 27, 2017

I also verified that none of the items in that test are running through the transform shader path.

@staktrace
Copy link
Contributor

@glennw Yeah this appears to be a pre-existing failure that cropped up sometime last night. I'm chasing down what caused it but it is unrelated to your patches so feel free to land your stuff. Bug 1403457 is tracking the failure if you're interested.

@kvark
Copy link
Member

kvark commented Sep 27, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 84a2959 has been approved by kvark

@bors-servo
Copy link
Contributor

⌛ Testing commit 84a2959 with merge 6007c07...

bors-servo pushed a commit that referenced this pull request Sep 27, 2017
Fix local clip rect being applied in transform shader.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1760)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: kvark
Pushing 6007c07 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants