Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed inner rectangle computation for transformed clips #2189

Merged
merged 2 commits into from Dec 8, 2017
Merged

Fixed inner rectangle computation for transformed clips #2189

merged 2 commits into from Dec 8, 2017

Conversation

mrobinson
Copy link
Member

@mrobinson mrobinson commented Dec 7, 2017 •
edited by larsbergstrom

This change is Reviewable

@mrobinson
Copy link
Member Author

This is #2177, but with the test reference image properly cropped as requested by @glennw.

@mrobinson
Copy link
Member Author

@bors-servo r=glennw

@bors-servo
Copy link
Contributor

📌 Commit 6b4ddfb has been approved by glennw

@bors-servo
Copy link
Contributor

⌛ Testing commit 6b4ddfb with merge f38bf98...

bors-servo pushed a commit that referenced this pull request Dec 8, 2017
Auto merge of #2189 - mrobinson:updated-2177, r=glennw
f38bf98 
Fixed inner rectangle computation for transformed clips

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2189)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: glennw
Pushing f38bf98 to master...

@bors-servo bors-servo merged commit 6b4ddfb into servo:master Dec 8, 2017
@mrobinson mrobinson deleted the updated-2177 branch December 8, 2017 13:18
@staktrace staktrace mentioned this pull request Dec 8, 2017
Closed
@staktrace
Copy link
Contributor

@mrobinson This PR caused a talos-g1 failure. Panic stack and details in https://bugzilla.mozilla.org/show_bug.cgi?id=1423203#c10 onwards.

@mrobinson
Copy link
Member Author

@kvark Any idea about this one? I'll try to investigate a bit tomorrow. If it seems like the issue is quite tricky we can use my original (super conservative and inefficient) approach until we figure this one out, in order to not block the WR update in Gecko.

@kvark
Copy link
Member

kvark commented Dec 8, 2017

@mrobinson yeah, I've been meaning to look into it but my Talos doesn't work and I got sucked into other things. Going with your original PR sounds fine to me, for now.

@kvark
Copy link
Member

kvark commented Dec 8, 2017

Actually, upon another consideration that code is incorrect (non-concervative). We should definitely back it out.

@mrobinson
Copy link
Member Author

Okay. I have a workaround PR here #2205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrobinson @bors-servo @staktrace @kvark