Early out from scene building if view is too large. #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the requested view size is larger than the maximum texture size supported by the hardware, early exit and fail to render. In the future, we could potentially render the scene in tiles, however this is a quick fix for an existing crash. Specifically, if Gecko is asked to open a very large window by JS, the first frame has a very large window size. On subsequent frames Gecko supplies a window size that is clamped to the actual monitor resolution. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1441392 and potentially https://bugzilla.mozilla.org/show_bug.cgi?id=1442921.
|
r? @kvark or anyone |
|
@bors-servo r+ |
|
📌 Commit 56841e3 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 15, 2018
Early out from scene building if view is too large. If the requested view size is larger than the maximum texture size supported by the hardware, early exit and fail to render. In the future, we could potentially render the scene in tiles, however this is a quick fix for an existing crash. Specifically, if Gecko is asked to open a very large window by JS, the first frame has a very large window size. On subsequent frames Gecko supplies a window size that is clamped to the actual monitor resolution. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1441392 and potentially https://bugzilla.mozilla.org/show_bug.cgi?id=1442921. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2524) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
kvark
approved these changes
Mar 15, 2018
|
@bors-servo r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 56841e3 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 15, 2018
Early out from scene building if view is too large. If the requested view size is larger than the maximum texture size supported by the hardware, early exit and fail to render. In the future, we could potentially render the scene in tiles, however this is a quick fix for an existing crash. Specifically, if Gecko is asked to open a very large window by JS, the first frame has a very large window size. On subsequent frames Gecko supplies a window size that is clamped to the actual monitor resolution. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1441392 and potentially https://bugzilla.mozilla.org/show_bug.cgi?id=1442921. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2524) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the requested view size is larger than the maximum texture
size supported by the hardware, early exit and fail to render.
In the future, we could potentially render the scene in tiles,
however this is a quick fix for an existing crash.
Specifically, if Gecko is asked to open a very large window by
JS, the first frame has a very large window size. On subsequent
frames Gecko supplies a window size that is clamped to the
actual monitor resolution.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1441392 and
potentially https://bugzilla.mozilla.org/show_bug.cgi?id=1442921.
This change is