Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary recording #2542

Merged
merged 1 commit into from Mar 19, 2018
Merged

Fix binary recording #2542

merged 1 commit into from Mar 19, 2018

Conversation

mrobinson
Copy link
Member

@mrobinson mrobinson commented Mar 19, 2018

At some point during scene building refactoring, messages important to
binary records stopped being included. This change ensures that they are
included again.


This change is Reviewable

At some point during scene building refactoring, messages important to
binary records stopped being included. This change ensures that they are
included again.
@mrobinson mrobinson requested a review from nical March 19, 2018 14:15
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@kvark
Copy link
Member

kvark commented Mar 19, 2018

@bors-servo r+

1 similar comment
@nical
Copy link
Contributor

nical commented Mar 19, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit fddd9b5 has been approved by kvark

@bors-servo
Copy link
Contributor

📌 Commit fddd9b5 has been approved by nical

@bors-servo
Copy link
Contributor

⌛ Testing commit fddd9b5 with merge ef7edeb...

bors-servo pushed a commit that referenced this pull request Mar 19, 2018
Fix binary recording

At some point during scene building refactoring, messages important to
binary records stopped being included. This change ensures that they are
included again.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2542)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster, status-travis
Approved by: nical
Pushing ef7edeb to master...

@bors-servo bors-servo merged commit fddd9b5 into servo:master Mar 19, 2018
@mrobinson mrobinson deleted the fix-wrench-dump branch March 19, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants