Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix for #2657, prevent subpixel in masks #2662

Merged
merged 1 commit into from Apr 16, 2018
Merged

hotfix for #2657, prevent subpixel in masks #2662

merged 1 commit into from Apr 16, 2018

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Apr 15, 2018 •
edited by larsbergstrom

people are noticing this a lot, so let's just do this now and figure out the more robust solutions later.

#2657 still needs a proper regression test, which I'll try to knock out tomorrow

This change is Reviewable

@glennw
Copy link
Member

glennw commented Apr 15, 2018

One CI failure:

REFTEST reftests/text/white-opacity.yaml == reftests/text/white-opacity.png
REFTEST TEST-UNEXPECTED-FAIL | reftests/text/white-opacity.yaml == reftests/text/white-opacity.png | image comparison, max difference: 72, number of differing pixels: 3247

I think it's probably just a reference image update, but I haven't looked in detail.

@Gankra
Copy link
Contributor Author

Gankra commented Apr 16, 2018

@bors-servo retry

@Gankra
Copy link
Contributor Author

Gankra commented Apr 16, 2018

It's weird that this is only affecting macos release..?

@jrmuizel
Copy link
Collaborator

We don't run reftests on macOS debug.

@Gankra
Copy link
Contributor Author

Gankra commented Apr 16, 2018 •
edited

as far as I can tell composite_op composite_mode doesn't actually factor in filters/preserve_3d properly yet, so this change needs to just be additive.

@glennw
Copy link
Member

glennw commented Apr 16, 2018

Ah, yes - I was thinking the composite mode would account for it, but I guess the parent of the 3d content will still have flat transform style.

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit e42f158 has been approved by glennw

@bors-servo
Copy link
Contributor

⌛ Testing commit e42f158 with merge 05de0ff...

bors-servo pushed a commit that referenced this pull request Apr 16, 2018
Auto merge of #2662 - Gankro:hotfix, r=glennw
05de0ff 
hotfix for #2657, prevent subpixel in masks

people are noticing this a lot, so let's just do this now and figure out the more robust solutions later.

#2657 still needs a proper regression test, which I'll try to knock out tomorrow

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2662)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: glennw
Pushing 05de0ff to master...

@bors-servo bors-servo merged commit e42f158 into servo:master Apr 16, 2018
@staktrace
Copy link
Contributor

@gankro just a heads up that this increased the fuzz required on the layout/reftests/transform-3d/preserve3d-1a.html reftest in gecko CI on windows.

@glennw glennw mentioned this pull request Apr 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gankra @glennw @jrmuizel @bors-servo @staktrace