Allow explicit indication of which missing pipelines are acceptable #2762
Conversation
webrender_api/src/display_list.rs
Outdated
| &mut self, | ||
| info: &LayoutPrimitiveInfo, | ||
| pipeline_id: PipelineId, | ||
| ignore_missing_pipeline: bool) |
|
Did you consider instead to have Gecko sending a provisional pipeline in case it needs to update it later? I don't quite like the fact that WR will just skip some elements, whatever they are, since it would make visual surprises for us, non-deterministically. If Gecko doesn't know when it will get the contents, it can at least figure out what the temporary contents should be for the mean time. |
|
I'm not sure how Gecko could send a provisional pipeline, it would require the UI process to block on the content process in order to know whether it needs to send one, and that is not allowed because it can lead to chrome hangs which are bad. Also the temporary contents would just be an empty display list so in practice the results should be the same. |
In some cases Gecko includes iframes for pipelines that are in other content processes, and the order in which the display lists reach the compositor is not deterministic. So it would be better if we could just have WebRender ignore those pipeline references. In all other cases we can assert.
|
Patch updated to fix style nit |
My point here is that it's Gecko who wants to mess things up by not providing the pipeline upfront for scene building, so it's the entity that should take responsibility for missing content, not the special handling in WR. |
|
Let's get this in, and continue discussing later. |
|
📌 Commit 5801963 has been approved by |
Allow explicit indication of which missing pipelines are acceptable In some cases Gecko includes iframes for pipelines that are in other content processes, and the order in which the display lists reach the compositor is not deterministic. So it would be better if we could just have WebRender ignore those pipeline references. In all other cases we can assert. This is desirable for https://bugzilla.mozilla.org/show_bug.cgi?id=1454042 r? @kvark <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2762) <!-- Reviewable:end -->
|
#TechnicalDebt |
|
☀️ Test successful - status-appveyor, status-taskcluster |
In some cases Gecko includes iframes for pipelines that are in other
content processes, and the order in which the display lists reach the
compositor is not deterministic. So it would be better if we could just
have WebRender ignore those pipeline references. In all other cases we
can assert.
This is desirable for https://bugzilla.mozilla.org/show_bug.cgi?id=1454042
r? @kvark
This change is