Add ProgramCacheObserver for an application can handle ProgramCache update #2764
Conversation
|
r? anyone. |
webrender/src/device.rs
Outdated
| pub struct ProgramBinary { | ||
| sources: ProgramSources, |
There was a problem hiding this comment.
can we only have this field for when serialize_program is featured?
There was a problem hiding this comment.
Yes, I am going to address it.
| binary, | ||
| format | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// The interfaces that an application can implement to handle ProgramCache update | ||
| pub trait ProgramCacheObserver { | ||
| fn notify_binary_added(&self, program_binary: &Arc<ProgramBinary>); |
There was a problem hiding this comment.
does the application need to have Arc<> here? would it make sense to provide &ProgramBinary instead?
There was a problem hiding this comment.
Arc<> is necessary here, since ProgramBinary is serialized and is stored to disk on worker thread.
webrender/src/lib.rs
Outdated
| @@ -48,7 +48,7 @@ extern crate cfg_if; | |||
| extern crate lazy_static; | |||
| #[macro_use] | |||
| extern crate log; | |||
| #[cfg(any(feature = "debugger", feature = "capture", feature = "replay"))] | |||
| #[cfg(any(feature = "debugger", feature = "capture", feature = "replay", feature = "serialize_program"))] | |||
There was a problem hiding this comment.
I wonder if we can just do feature = "serde" here
There was a problem hiding this comment.
I will update it in a next pull request.
webrender/src/device.rs
Outdated
| } | ||
| ) | ||
| } | ||
| pub fn load_program_binary(&self, program_binary: Arc<ProgramBinary>) { |
There was a problem hiding this comment.
where is this used or meant to be used?
There was a problem hiding this comment.
Application uses the function to store ProgramBinary to ProgramCache. The ProgramBinary is loaded from disk.
| @@ -15,6 +15,7 @@ capture = ["webrender_api/serialize", "ron", "serde", "debug_renderer"] | |||
| replay = ["webrender_api/deserialize", "ron", "serde"] | |||
| debug_renderer = [] | |||
| pathfinder = ["pathfinder_font_renderer", "pathfinder_gfx_utils", "pathfinder_partitioner", "pathfinder_path_utils"] | |||
| serialize_program = ["serde"] | |||
There was a problem hiding this comment.
I will add the testing.
|
thank you! |
|
📌 Commit f478f0a has been approved by |
Add ProgramCacheObserver for an application can handle ProgramCache update The pull request has some changes that application can pre-load program binary to ProgramCache and can handle ProgramCache update for saving program binary. Related info is in [Bug 1418202](https://bugzilla.mozilla.org/show_bug.cgi?id=1418202) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2764) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
The pull request has some changes that application can pre-load program binary to ProgramCache and can handle ProgramCache update for saving program binary.
Related info is in Bug 1418202
This change is