Add functionality to enable Servo to fetch scroll positions for all stacking contexts. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacking contexts. Requires servo/webrender_traits#55. Partially addresses servo/servo#11108.
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
May 25, 2016
WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses servo#11108.
|
@pcwalton This part looks good to me - just a comment / question on the related servo PR. |
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
May 27, 2016
WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses servo#11108.
|
@bors-servo: r=glennw |
|
📌 Commit 3df0874 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 27, 2016
Add functionality to enable Servo to fetch scroll positions for all stacking contexts. Requires servo/webrender_traits#55. Partially addresses servo/servo#11108. r? @glennw
|
☀️ Test successful - travis |
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
May 27, 2016
WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses servo#11108.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
May 27, 2016
script: Keep the DOM-side viewport up to date when scrolling happens in WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses #11108. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11398) <!-- Reviewable:end -->
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
May 28, 2016
WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses servo#11108.
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
May 28, 2016
WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses servo#11108.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
May 28, 2016
script: Keep the DOM-side viewport up to date when scrolling happens in WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses #11108. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11398) <!-- Reviewable:end -->
pcwalton
added a commit
to pcwalton/servo
that referenced
this pull request
May 31, 2016
WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses servo#11108.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jun 1, 2016
script: Keep the DOM-side viewport up to date when scrolling happens in WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses #11108. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11398) <!-- Reviewable:end -->
avadacatavra
pushed a commit
to avadacatavra/servo
that referenced
this pull request
Jun 10, 2016
WebRender. This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses servo#11108.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…hen scrolling happens in WebRender (from pcwalton:webrender-viewport); r=glennw This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses #11108. r? glennw Source-Repo: https://github.com/servo/servo Source-Revision: 27d1f182713077395426a53a9c91ec35c95887ee UltraBlame original commit: f728a22bff8d6fd27c38a952b9142db0d243005a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…hen scrolling happens in WebRender (from pcwalton:webrender-viewport); r=glennw This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses #11108. r? glennw Source-Repo: https://github.com/servo/servo Source-Revision: 27d1f182713077395426a53a9c91ec35c95887ee UltraBlame original commit: f728a22bff8d6fd27c38a952b9142db0d243005a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…hen scrolling happens in WebRender (from pcwalton:webrender-viewport); r=glennw This happens asynchronously, just as it does in non-WebRender mode. This functionality is a prerequisite for doing proper display-list-based hit testing in WebRender, since it moves the scroll offsets into Servo (and, specifically, into the script thread, enabling iframe event forwarding) instead of keeping them private to WebRender. Requires servo/webrender_traits#55 and servo/webrender#277. Partially addresses #11108. r? glennw Source-Repo: https://github.com/servo/servo Source-Revision: 27d1f182713077395426a53a9c91ec35c95887ee UltraBlame original commit: f728a22bff8d6fd27c38a952b9142db0d243005a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires servo/webrender_traits#55.
Partially addresses servo/servo#11108.
r? @glennw