Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support double style borders in new border brush path. #2779

Closed
wants to merge 1 commit into from

Conversation

gw3583
Copy link
Contributor

@gw3583 gw3583 commented May 25, 2018

This change is Reviewable

@gw3583
Copy link
Contributor Author

gw3583 commented May 25, 2018

r? @kvark

This also includes #2778, which can either be reviewed / merged separately or as part of this PR.

Pending try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=16a0fc0f6cf2fb948888fac217b17409ec0cc7a9

@gw3583
Copy link
Contributor Author

gw3583 commented May 27, 2018

Rebased, but needs some investigation into a couple of reftest failures first.

@gw3583
Copy link
Contributor Author

gw3583 commented May 27, 2018

Upon investigating this, there is just one additional reftest failure over what is currently expected. The differing pixels in border-striped-curve has gone from 930 -> 931. So we can add one extra pixel of fuzz and this should be ready to merge once it is reviewed.

@gw3583
Copy link
Contributor Author

gw3583 commented May 28, 2018

Closing in favor or #2784.

@gw3583 gw3583 closed this May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant