Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support double, groove, ridge borders in new border brush path. #2784

Merged
merged 3 commits into from
May 30, 2018
Merged

Support double, groove, ridge borders in new border brush path. #2784

merged 3 commits into from
May 30, 2018

Commits on May 30, 2018

  1. Support double, groove, ridge borders in new border brush path.

    @gw3583
    gw3583 committed May 30, 2018
    Configuration menu
    Copy the full SHA
    2f13b4c View commit details
    Browse the repository at this point in the history

  2. Defer building of instances unless render task is stale. 

    Also reduce clones of the brush segments.

This is an optimization for the common case of a lot of similar
borders. However, it mainly prep work for supporting dashing and
dotting style support. In these cases, we may generate a large
number of instances, and so it would be inefficient to generate
these unconditionally. Instead, it's much more efficient to only
generate them when there is no matching valid cached render task.
    @gw3583
    gw3583 committed May 30, 2018
    Configuration menu
    Copy the full SHA
    abd6bed View commit details
    Browse the repository at this point in the history

  3. Address review comments.

    @gw3583
    gw3583 committed May 30, 2018
    Configuration menu
    Copy the full SHA
    9985a99 View commit details
    Browse the repository at this point in the history