Round blur support up to the nearest even number of pixels. #3126
Conversation
|
How do I mark various failing Gecko tests as fuzzy? |
|
With a Gecko patch that modifies the |
|
@mstange Does that need to land before or after the corresponding patch lands in the WR repository? |
|
I generally get @jrmuizel or @staktrace to sign off on the fuzziness increases being OK here in a comment, and then they update them as part of the WR update. |
|
It needs to land together with the WebRender update that pulls that change into Gecko. So just attach the patch to the wr-future-update bug and Jeff or Kats will include it. |
|
Gotcha, thanks. |
I'm pretty confident this is correct--it's either just as accurate or more accurate than the current implementation--so it'll let me sort out which test failures, if any, from servo#3028 and servo#3122 are true regressions.
pcwalton
force-pushed
the
blur-even-support
branch
from
b1b1f81
to
61d43da
Compare
|
I verified all test differences are imperceptible. Will carry forward review once tests pass unless anyone has objections. I will also submit a patch to fix Gecko test suite failures. |
|
@bors-servo: r=kvark |
|
📌 Commit 61d43da has been approved by |
Round blur support up to the nearest even number of pixels. I'm pretty confident this is correct--it's either just as accurate or more accurate than the current implementation--so it'll let me sort out which test failures, if any, from #3028 and #3122 are true regressions. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3126) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
I'm pretty confident this is correct--it's either just as accurate or more
accurate than the current implementation--so it'll let me sort out which test failures, if any, from #3028 and #3122 are true regressions.
This change is