Properly support tiling clip mask images. #3220
Conversation
|
I'd prefer not to land it yet, since the code is basically copy-pasted from image tiling, and it could get some cleanup. Just want to confirm this approach is the right way to fix this. I also need to write some reftests for this, but testing of blob images is none as of right now... So I'll add some Gecko reftests to the bug. If this an acceptable solution I'll clean up and such before get it landed. |
emilio
force-pushed
the
tiling-masks
branch
2 times, most recently
from
71d3c7d
to
a75e350
Compare
|
I think this should be basically ready for review. I added a bunch of cleanup commits that made me feel less bad about copying the image tiling code, and a bunch of tests (will add reftests that check the blob image stuff in Gecko after this lands). Once thing that may be problematic is that if I understand correctly this I'm drawing the whole visible area for each tile just to In any case... r? :) |
There was a problem hiding this comment.
Reviewed 14 of 16 files at r2, 5 of 5 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @emilio)
wrench/reftests/mask/checkerboard-tiling.yaml, line 1 at r3 (raw file):
---
It'd be good to have a brief comment at the top of each test explaining what functionality / feature it is testing.
wrench/reftests/mask/checkerboard-tiling.yaml, line 10 at r3 (raw file):
rect: [0, 0, 200, 200] repeat: false tile-size: 37 # Intentional
An explanation of why would be good here.
|
This basically looks good to me (a couple of minor nits). It'd be good to get @nical to take a look over the image tiling changes, if possible, as well. |
There was a problem hiding this comment.
Reviewable status: 18 of 19 files reviewed, 2 unresolved discussions (waiting on @gw3583 and @emilio)
wrench/reftests/mask/checkerboard-tiling.yaml, line 1 at r3 (raw file):
Previously, gw3583 (Glenn Watson) wrote…
It'd be good to have a brief comment at the top of each test explaining what functionality / feature it is testing.
I have left a comment on this one. The only tests that I introduced per se are this one and mask-perspective*, whose purpose is on the test.
The rest of this are copies of existing tests, but with tiling, to ensure that tiled and untiled output is the same.
wrench/reftests/mask/checkerboard-tiling.yaml, line 10 at r3 (raw file):
Previously, gw3583 (Glenn Watson) wrote…
An explanation of why would be good here.
Done.
|
Looks good to me! |
|
Thanks! @bors-servo r=gw3583,nical |
|
📌 Commit 0800db0 has been approved by |
|
Trying to wake up bors |
|
@bors-servo retry |
|
@bors-servo r- |
|
@bors-servo r+ retry force |
|
@bors-servo r=gw3583 |
|
📌 Commit 0800db0 has been approved by |
|
@bors-servo r=gw3583,nical |
|
📌 Commit 8682c13 has been approved by |
Fixes #2852.
This change is