Extract nine patch segment generation into create_nine_patch_segments.

[gw3583]

This change is 

[gw3583]

The patches I'm working on towards border interning are getting quite large, so I'm trying to split it up into smaller chunks. This patch is a straightforward move of code from flattening into a reusable function. We will need this later since the segment generating when interning only happens when a unique primitive is created, not every time a new scene is built.

r? @kvark or anyone

[gw3583]

Added a follow up comment that reduces the size of PrimitiveInstance, and ensures that interned primitives don't use the gpu cache handle that (was) in the instance.

Pending try with both patches:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0348b4407434029ec50b94b3ab0e0babc44573dd

[gw3583]

Try run looks good.

[kvark]

Reviewed 2 of 2 files at r1, 3 of 3 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gw3583)

---

webrender/src/border.rs, line 1146 at r2 (raw file):

}

pub fn create_nine_patch_segments(

I assume this code isn't changed, just moved over

---

webrender/src/prim_store.rs, line 951 at r2 (raw file):

    }

    fn write_gpu_blocks(

this method is now inconsistent with all the other write_gpu_blocks, which receive GpuDataRequest. Let's rename it to avoid confusion

[gw3583]

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @kvark)

---

webrender/src/border.rs, line 1146 at r2 (raw file):

Previously, kvark (Dzmitry Malyshau) wrote…

I assume this code isn't changed, just moved over

Yep, that's right.

---

webrender/src/prim_store.rs, line 951 at r2 (raw file):

Previously, kvark (Dzmitry Malyshau) wrote…

this method is now inconsistent with all the other write_gpu_blocks, which receive GpuDataRequest. Let's rename it to avoid confusion

Renamed to write_gpu_blocks_if_required

[gw3583]

@bors-servo r=kvark

[bors-servo]

📌 Commit 6599760 has been approved by kvark

[bors-servo]

⌛ Testing commit 6599760 with merge fbf6516...

[bors-servo]

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing fbf6516 to master...