Remove local_rect_changed from PictureState. #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can now be handled internally, and removes one more need for the PictureState structure during the main traversal.
|
Try run looks good. |
kvark
approved these changes
Nov 13, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Nice try! :D |
|
📌 Commit 27cc9ec has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 13, 2018
Remove local_rect_changed from PictureState. This can now be handled internally, and removes one more need for the PictureState structure during the main traversal. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3302) <!-- Reviewable:end -->
|
💔 Test failed - status-taskcluster |
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Nov 13, 2018
Remove local_rect_changed from PictureState. This can now be handled internally, and removes one more need for the PictureState structure during the main traversal. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3302) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can now be handled internally, and removes one more need
for the PictureState structure during the main traversal.
This change is