Don't ignore the clip on the stack for reference frames and clips #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes sense. Does this have any impact on the number of clip chains that will end up being assigned to stacking context (pictures). (i.e. is the extra intermediate surface generation at [1] going to be triggered more with this change?). [1] webrender/webrender/src/display_list_flattener.rs Line 1046 in 9ec08a4 |
|
The |
gw3583
approved these changes
Nov 16, 2018
|
Looks good - and yes, more surface annotations in reftests is a great idea. |
|
Added a few checks to the reftests in the new commit. Confirmed locally that they pass with and without the new code. |
|
📌 Commit 1a74392 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 16, 2018
Don't ignore the clip on the stack for reference frames and clips Similar to #3311, this is a prelude to #3251, with the main purpose of getting rid of Gecko's hack in https://searchfox.org/mozilla-central/rev/d850d799a0009f851b5535580e0a8b4bb2c591d7/gfx/layers/wr/ClipManager.cpp#224 It also makes sense for WR in isolation (for the current clip/stack model, at least): in those spots addressed, we used to ignore the clip ID on the stack, only to re-interpret (smuggle!) the scroll ID as a clip. Now we are actually using the clip ID more consistently. See also - #3251 (comment) Gecko try (that disables the hack in addition to having the WR change): https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=212038686&revision=c10e5d839e024ba451a6622fa611c3525457f3ff (Looks green! 🎉 ) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3315) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 18, 2018
Previously, WebRender ignored clip_node_id on the clip/scroll stack when pushing clips or reference frames. This got fixed to be more consistent in: servo/webrender#3315 Now Gecko can use the clip chains generated for display items naturally, instead of smuggling the last clip through the scroll_node_id, which is what was happening in this hacky code branch being removed. Differential Revision: https://phabricator.services.mozilla.com/D12216 --HG-- extra : moz-landing-system : lando
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Nov 18, 2018
Previously, WebRender ignored clip_node_id on the clip/scroll stack when pushing clips or reference frames. This got fixed to be more consistent in: servo/webrender#3315 Now Gecko can use the clip chains generated for display items naturally, instead of smuggling the last clip through the scroll_node_id, which is what was happening in this hacky code branch being removed. Differential Revision: https://phabricator.services.mozilla.com/D12216
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 20, 2018
Before servo/webrender#3315 this rendered a red square under the green square on WR.
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Nov 21, 2018
Before servo/webrender#3315 this rendered a red square under the green square on WR.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
Previously, WebRender ignored clip_node_id on the clip/scroll stack when pushing clips or reference frames. This got fixed to be more consistent in: servo/webrender#3315 Now Gecko can use the clip chains generated for display items naturally, instead of smuggling the last clip through the scroll_node_id, which is what was happening in this hacky code branch being removed. Differential Revision: https://phabricator.services.mozilla.com/D12216 UltraBlame original commit: aa0c5bc2a99ee57f82ca44da461ebd9870af4275
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
Previously, WebRender ignored clip_node_id on the clip/scroll stack when pushing clips or reference frames. This got fixed to be more consistent in: servo/webrender#3315 Now Gecko can use the clip chains generated for display items naturally, instead of smuggling the last clip through the scroll_node_id, which is what was happening in this hacky code branch being removed. Differential Revision: https://phabricator.services.mozilla.com/D12216 UltraBlame original commit: aa0c5bc2a99ee57f82ca44da461ebd9870af4275
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
Before servo/webrender#3315 this rendered a red square under the green square on WR. UltraBlame original commit: 5df0edf84a229f28caf8de076344d499165a6ed3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
Before servo/webrender#3315 this rendered a red square under the green square on WR. UltraBlame original commit: 5df0edf84a229f28caf8de076344d499165a6ed3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
Previously, WebRender ignored clip_node_id on the clip/scroll stack when pushing clips or reference frames. This got fixed to be more consistent in: servo/webrender#3315 Now Gecko can use the clip chains generated for display items naturally, instead of smuggling the last clip through the scroll_node_id, which is what was happening in this hacky code branch being removed. Differential Revision: https://phabricator.services.mozilla.com/D12216 UltraBlame original commit: aa0c5bc2a99ee57f82ca44da461ebd9870af4275
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
Before servo/webrender#3315 this rendered a red square under the green square on WR. UltraBlame original commit: 5df0edf84a229f28caf8de076344d499165a6ed3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3311, this is a prelude to #3251, with the main purpose of getting rid of Gecko's hack in https://searchfox.org/mozilla-central/rev/d850d799a0009f851b5535580e0a8b4bb2c591d7/gfx/layers/wr/ClipManager.cpp#224
It also makes sense for WR in isolation (for the current clip/stack model, at least): in those spots addressed, we used to ignore the clip ID on the stack, only to re-interpret (smuggle!) the scroll ID as a clip. Now we are actually using the clip ID more consistently. See also - #3251 (comment)
Gecko try (that disables the hack in addition to having the WR change):
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=212038686&revision=c10e5d839e024ba451a6622fa611c3525457f3ff
(Looks green! 🎉 )
This change is