New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure coord system ID is propagated for non-invertible nodes. #3316

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Collaborator

gw3583 commented Nov 15, 2018

An invariant required by the clip-scroll tree is that any child
spatial node must have a coordinate system ID >= of the parent
node's coordinate system ID.

This patch changes the update_transform traversal to ensure that
even when a non-invertible transform is detected, the coordinate
system ID from the parent is still propagated.

This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1502717.


This change is Reviewable

Ensure coord system ID is propagated for non-invertible nodes.
An invariant required by the clip-scroll tree is that any child
spatial node must have a coordinate system ID >= of the parent
node's coordinate system ID.

This patch changes the update_transform traversal to ensure that
even when a non-invertible transform is detected, the coordinate
system ID from the parent is still propagated.

This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1502717.
@gw3583

This comment has been minimized.

@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Nov 16, 2018

Try looks good.

@kvark

This comment has been minimized.

Member

kvark commented Nov 16, 2018

Looks straightforward. Thank you for fixing that nasty issue!
@bors-servo r+

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 16, 2018

📌 Commit 7f889cc has been approved by kvark

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 16, 2018

⌛️ Testing commit 7f889cc with merge dc442bf...

bors-servo added a commit that referenced this pull request Nov 16, 2018

Auto merge of #3316 - gw3583:fix-crash, r=kvark
Ensure coord system ID is propagated for non-invertible nodes.

An invariant required by the clip-scroll tree is that any child
spatial node must have a coordinate system ID >= of the parent
node's coordinate system ID.

This patch changes the update_transform traversal to ensure that
even when a non-invertible transform is detected, the coordinate
system ID from the parent is still propagated.

This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1502717.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3316)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 16, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing dc442bf to master...

@bors-servo bors-servo merged commit 7f889cc into servo:master Nov 16, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment