Ensure coord system ID is propagated for non-invertible nodes. #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An invariant required by the clip-scroll tree is that any child spatial node must have a coordinate system ID >= of the parent node's coordinate system ID. This patch changes the update_transform traversal to ensure that even when a non-invertible transform is detected, the coordinate system ID from the parent is still propagated. This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1502717.
|
Try looks good. |
|
Looks straightforward. Thank you for fixing that nasty issue! |
|
📌 Commit 7f889cc has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 16, 2018
Ensure coord system ID is propagated for non-invertible nodes. An invariant required by the clip-scroll tree is that any child spatial node must have a coordinate system ID >= of the parent node's coordinate system ID. This patch changes the update_transform traversal to ensure that even when a non-invertible transform is detected, the coordinate system ID from the parent is still propagated. This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1502717. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3316) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An invariant required by the clip-scroll tree is that any child
spatial node must have a coordinate system ID >= of the parent
node's coordinate system ID.
This patch changes the update_transform traversal to ensure that
even when a non-invertible transform is detected, the coordinate
system ID from the parent is still propagated.
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1502717.
This change is