don't disable subpixel positioning for a text run when it is requested #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsalzman
force-pushed
the
subpix-pos-fix
branch
from
e992c53
to
3fdfef9
Compare
|
@bors-servo r+ |
|
📌 Commit 3fdfef9 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 16, 2018
don't disable subpixel positioning for a text run when it is requested This resolves Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1506053 Gecko is generating metrics with DWrite assuming subpixel positioning. So if it requests WR use subpixel position, we have to honor it, otherwise the rendered glyphs will not match up. It's not really tenable to just disable subpixel positioning on the metrics side, since that requires using entirely different render modes (GDI vs. ClearType) which may significantly impact appearance. The line that disabled subpixel positioning did not even previously exist till I accidentally added it in 58ccf52 This just undoes that mistake. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3317) <!-- Reviewable:end -->
|
💔 Test failed - status-appveyor |
|
|
@lsalzman Looks like a failing reftest on CI. |
|
@bors-servo r=nical |
|
📌 Commit 1c36253 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 21, 2018
don't disable subpixel positioning for a text run when it is requested This resolves Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1506053 Gecko is generating metrics with DWrite assuming subpixel positioning. So if it requests WR use subpixel position, we have to honor it, otherwise the rendered glyphs will not match up. It's not really tenable to just disable subpixel positioning on the metrics side, since that requires using entirely different render modes (GDI vs. ClearType) which may significantly impact appearance. The line that disabled subpixel positioning did not even previously exist till I accidentally added it in 58ccf52 This just undoes that mistake. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3317) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves Gecko bug https://bugzilla.mozilla.org/show_bug.cgi?id=1506053
Gecko is generating metrics with DWrite assuming subpixel positioning. So if it requests WR use subpixel position, we have to honor it, otherwise the rendered glyphs will not match up. It's not really tenable to just disable subpixel positioning on the metrics side, since that requires using entirely different render modes (GDI vs. ClearType) which may significantly impact appearance.
The line that disabled subpixel positioning did not even previously exist till I accidentally added it in 58ccf52
This just undoes that mistake.
This change is