batch: Use the right clip rect for drop shadows. #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really want to translate the clip, and furthermore, the picture clip rect for these pictures is always the max rect, so it's not really what we want. https://searchfox.org/mozilla-central/rev/49e78df13e7a505827a3a86daae9efdf827133c6/gfx/wr/webrender/src/display_list_flattener.rs#1472 This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1496019
|
... which looks green, with an unexpected pass even. |
|
@bors-servo r+ |
|
📌 Commit fbcfd98 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 17, 2018
batch: Use the right clip rect for drop shadows. We don't really want to translate the clip, and furthermore, the picture clip rect for these pictures is always the max rect, so it's not really what we want. https://searchfox.org/mozilla-central/rev/49e78df13e7a505827a3a86daae9efdf827133c6/gfx/wr/webrender/src/display_list_flattener.rs#1472 This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1496019 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3421) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 17, 2018
…f1b9707f2d6c (WR PR #3421). r=kats servo/webrender#3421 Differential Revision: https://phabricator.services.mozilla.com/D14739 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 18, 2018
…f1b9707f2d6c (WR PR #3421). r=kats servo/webrender#3421 Differential Revision: https://phabricator.services.mozilla.com/D14739
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 20, 2018
…e0f1b9707f2d6c (WR PR #3421). r=kats, a=RyanVM servo/webrender#3421 --HG-- extra : source : b7d06736403e5f07f8d1b68ea7345f6486eea4eb extra : histedit_source : 6784685747abba47faa0ce00886211aa2b73094d
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Dec 21, 2018
…e0f1b9707f2d6c (WR PR #3421). r=kats, a=RyanVM servo/webrender#3421
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…f1b9707f2d6c (WR PR #3421). r=kats servo/webrender#3421 Differential Revision: https://phabricator.services.mozilla.com/D14739 UltraBlame original commit: b7d06736403e5f07f8d1b68ea7345f6486eea4eb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…f1b9707f2d6c (WR PR #3421). r=kats servo/webrender#3421 Differential Revision: https://phabricator.services.mozilla.com/D14739 UltraBlame original commit: b7d06736403e5f07f8d1b68ea7345f6486eea4eb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…f1b9707f2d6c (WR PR #3421). r=kats servo/webrender#3421 Differential Revision: https://phabricator.services.mozilla.com/D14739 UltraBlame original commit: b7d06736403e5f07f8d1b68ea7345f6486eea4eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really want to translate the clip, and furthermore, the picture clip
rect for these pictures is always the max rect, so it's not really what we want.
https://searchfox.org/mozilla-central/rev/49e78df13e7a505827a3a86daae9efdf827133c6/gfx/wr/webrender/src/display_list_flattener.rs#1472
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1496019
This change is