Sync changes from mozilla-central gfx/wr #4848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And reorganize the branches in get_prim_render_strategy to reduce nesting Differential Revision: https://phabricator.services.mozilla.com/D203919 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/f89ecc056f703879d05ea5fb90055c2dda7c6955
…or Gecko r=jrmuizel Make glean an optional dependency that is only enabled when building WebRender for Gecko. Differential Revision: https://phabricator.services.mozilla.com/D204059 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/10af6b2ff03bd7512d53f3ed02f7e83dba7c57ba
…eviewers,mach-reviewers Depends on D204347 Differential Revision: https://phabricator.services.mozilla.com/D204348 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/1ca35c868a8a8ebc010501bf4cfb212dae663e01
|
@bors-servo r=auto |
|
📌 Commit 944d370 has been approved by |
|
🔒 Merge conflict |
…ct. r=gfx-reviewers,gw While investigating why get_surface_rect sometimes returns an empty rect (causing bad render task sizes), I noticed that all users of get_surface_rect use it to size surfaces, rely on the returned rect to be snapped to integer coordinates, and some even round the coordinates a second time. The documentation of the function states that its purpose is to provide a rect suitable for surface allocation. This patch bakes the expectation into the type and removes some redundant operations. Differential Revision: https://phabricator.services.mozilla.com/D203738 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/eae4f8752721b2e1361c4c1ea57e038a01e557ea
…ace_rect. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D203912 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/4effb464f6046bf35abd5e2fdc7edf49312acedc
…zed rect. r=gw Differential Revision: https://phabricator.services.mozilla.com/D204198 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/dd1b3d97c6a88101781dd141b8c9b5ad3949a413
…rect. r=gw Differential Revision: https://phabricator.services.mozilla.com/D204228 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/987284103c26599be1cfe7738d0780c6253fb5cb
…ausing webrender bustages in conftest.c CLOSED TREE Backed out changeset 987284103c26 (bug 1769492) Backed out changeset dd1b3d97c6a8 (bug 1769492) Backed out changeset 4effb464f604 (bug 1883863) Backed out changeset eae4f8752721 (bug 1883873) [ghsync] From https://hg.mozilla.org/mozilla-central/rev/d9ad55d66d8523561815b7fbeef13f84428eb55b
|
@bors-servo r=auto |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 944d370 has been approved by |
The vClipRadii varying being changed to mediump is causing borders to be clipped incorrectly at certain zoom levels. This patch reverts it to highp to avoid the issue. As a precaution it conservatively reverts several other varyings in this shader to be highp as well. Although the others are not responsible for the issue reported in this bug, using mediump for varyings related to positioning could cause similar problems. Differential Revision: https://phabricator.services.mozilla.com/D204507 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/7afa472a8cac8d854d0d9c68a3c18a590978fffe
|
@bors-servo r=auto |
|
📌 Commit 6e4ff49 has been approved by |
…ct. r=gfx-reviewers,gw While investigating why get_surface_rect sometimes returns an empty rect (causing bad render task sizes), I noticed that all users of get_surface_rect use it to size surfaces, rely on the returned rect to be snapped to integer coordinates, and some even round the coordinates a second time. The documentation of the function states that its purpose is to provide a rect suitable for surface allocation. This patch bakes the expectation into the type and removes some redundant operations. Differential Revision: https://phabricator.services.mozilla.com/D203738 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/038ff8035b29b9052311d9cf616a2aced886896c
…ace_rect. r=gfx-reviewers,gw Differential Revision: https://phabricator.services.mozilla.com/D203912 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/38cbac05cbe6c61198346214bfb7a993133394e9
…zed rect. r=gw Differential Revision: https://phabricator.services.mozilla.com/D204198 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/f7eaa2650ed500ccfd3df27f4733087722b9b412
…rect. r=gw Differential Revision: https://phabricator.services.mozilla.com/D204228 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/841e7dd0db80a53d9937286637f15cb2579eb9c4
Webrender's glslopt-optimized shaders encounter a miscompilation on some Adreno driver versions regarding fetching empty clip tasks. This patch reshuffles the code in such a way as to avoid the bug. Unfortunately the specific cause of the miscompilation remains unknown, meaning we must take extra care not to regress it in the future. Differential Revision: https://phabricator.services.mozilla.com/D204864 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/488c57bb8ceed6da3f0be935156a480cdb92bc32
|
@bors-servo r=auto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.