Support secondary openxr observer view #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
secondary-view
branch
from
035a048
to
d69af86
Compare
|
The broad outline LGTM, though I think this and the API redesign I'm in the middle of are likely to tread on each other's toes. |
|
Yeah i've split up the commits by area of code affected and i expect only the last one to actually have issues here. |
Manishearth
force-pushed
the
secondary-view
branch
3 times, most recently
from
1131aa6
to
713ae64
Compare
|
☔ The latest upstream changes (presumably #174) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
force-pushed
the
secondary-view
branch
from
91f04e6
to
21966a5
Compare
Manishearth
force-pushed
the
secondary-view
branch
from
21966a5
to
be02777
Compare
|
@bors-servo r=asajeffrey |
|
📌 Commit be02777 has been approved by |
|
☀️ Test successful - checks-travis |
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 13, 2020
Update webxr with secondary view support Blocked on servo/webxr#171 , untested
bors-servo
added a commit
to servo/servo
that referenced
this pull request
May 13, 2020
Update webxr with secondary view support Blocked on servo/webxr#171 , untested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servo side: servo/servo#26458
My openxrs branch will need to be pushed to servo/openxrs before landing: servo/openxrs#1