Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API sketch for X509 cert chain verification #102

Closed

Conversation

kislyuk
Copy link

@kislyuk kislyuk commented Apr 9, 2023

See #77 for discussion

Copy link
Owner

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'm happy with this design, I'd like to lose the creation of an ssl.SSLContext object if possible. I also wonder how we're going to configure certificate verification for platforms, things like CRLs, etc?

@@ -0,0 +1,10 @@
"""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's lift this prose into it's own documentation page as a warning?

@sethmlarson
Copy link
Owner

Hey @kislyuk, I have some more time to spend on OSS now. Are you interested in picking this PR back up?

@kislyuk
Copy link
Author

kislyuk commented Aug 19, 2023

I am definitely interested in getting this PR finished but would welcome any help! I had to pause work on it because of too many other things going on. If you want to take over any part of it I would very much appreciate it, otherwise I will try to get back to it over the course of the next few weekends.

@sethmlarson
Copy link
Owner

Hey @kislyuk, since it's been a bit on this PR I am not sure if you'll get to this one (no worries if not!) I'm going to close it but let me know if you'd like to pick it back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants