feat: add kubernetes service registration #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
looks like the result is, using the standard flow described in the README with the latest code changes, the public IP listed does not navigate to the vault UI, and instead hangs - and as far as the API, that too will hang. |
|
@sethvargo re: #95 |
bchrobot
added a commit
to politics-rewired/vault-on-gke
that referenced
this pull request
Aug 12, 2021
PR sethvargo#94 relies on a feature introduced in Vault 1.4.0. This updates Vault to the latest version fixing sethvargo#95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://www.vaultproject.io/docs/configuration/service-registration/kubernetes
And hashicorp/vault#9073 for why
"patch"verb is included.