Update for Fastboot 1.0 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knownasilya
reviewed
Jul 7, 2017
package.json
Outdated
| @@ -1,15 +1,15 @@ | |||
| { | |||
| "name": "ember-cli-new-version", | |||
| "version": "1.1.0", | |||
| "version": "1.2.0", | |||
There was a problem hiding this comment.
Please don't bump the version 👍
There was a problem hiding this comment.
Ha yes forgot to change this back. When testing the package lock kept causing a cached version to be installed so took drastic measures
knownasilya
reviewed
Jul 7, 2017
package.json
Outdated
| "ember-load-initializers": "^1.0.0", | ||
| "ember-resolver": "^4.2.1", | ||
| "ember-source": "~2.14.0", | ||
| "ember-welcome-page": "^3.1.1", |
There was a problem hiding this comment.
Could you also remove this dependency? Thanks!
knownasilya
requested changes
Jul 7, 2017
knownasilya
reviewed
Jul 7, 2017
| @@ -37,6 +36,8 @@ export default Ember.Component.extend({ | |||
| clearTimeout(currentTimeout); | |||
| } | |||
|
|
|||
| if(!Ember.$) { return; } | |||
There was a problem hiding this comment.
Also, could you make this a multiline if, just so it goes with the rest of the syntax?
|
Thanks all for keeping things going 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.