Added check for different variables length.

sethyuan · Mar 16, 2013 · c1e6b62 · c1e6b62
1 parent f8617c5
commit c1e6b62
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/xtabs.js b/lib/xtabs.js
@@ -273,7 +273,12 @@ table = function(x) {
     varNames = Array.prototype.slice.call(arguments, 1, arguments.length);
     vars = new Array(varNames.length);
     for (var i = 0; i < varNames.length; i++) {
-      vars[i] = factor(x[varNames[i]], useNull);
+      vars[i] = x[varNames[i]];
+    }
+    if (!vars.every(function(v) { return v.length === vars[0].length }))
+      throw new Error("variables must have the same length.");
+    for (var i = 0; i < varNames.length; i++) {
+      vars[i] = factor(vars[i], useNull);
     }
   }
   return constructTable(varNames, vars);

diff --git a/test/xtabs.js b/test/xtabs.js
@@ -73,6 +73,16 @@ describe("xtabs", function() {
     });
   });
 
+  it("diffrent length data", function() {
+    var data = {
+      department: ["MIS", "MIS", "HR", "TR", null, "TR", "MIS"],
+      gender: ["M", "F", null, "M", "F", "M"]
+    };
+    (function() {
+      xtabs.table(data, "department", "gender");
+    }).should.throw();
+  });
+
   it("single factor", function() {
     var x = xtabs.factor(["Male", "Female", "Female", "Female", "Male", "Female"]),
         t = xtabs.table(x);