Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running both UI's #788

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Running both UI's #788

merged 2 commits into from
Apr 27, 2023

Conversation

sofiaromorales
Copy link
Member

No description provided.

Copy link
Collaborator

@Ovifer13 Ovifer13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to change SITE_ROOT in constants.js, and do something to validate that we are using 6003 or 6002.
I was researching to see if there's a way to know what port you are in and change the conditions, instead of 6002, redirect to 6003.

SITE_ROOT: process.env.NODE_ENV == 'production'
? process.env.SITE_URL
: 'http://localhost:6002',

@sofiaromorales
Copy link
Member Author

I think we also need to change SITE_ROOT in constants.js, and do something to validate that we are using 6003 or 6002. I was researching to see if there's a way to know what port you are in and change the conditions, instead of 6002, redirect to 6003.

SITE_ROOT: process.env.NODE_ENV == 'production'
? process.env.SITE_URL
: 'http://localhost:6002',

After discussing this with @otech47 we decided to leave this as it is, for now, the problem with the redirect only happens when logging in, so not a big deal

@sofiaromorales sofiaromorales merged commit 00e3ebc into develop Apr 27, 2023
@sofiaromorales sofiaromorales deleted the sr/issue-786/run-both-UIs branch April 27, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants