Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer: bash-script is to replace by go #44

Merged
merged 4 commits into from
Sep 26, 2019
Merged

Signer: bash-script is to replace by go #44

merged 4 commits into from
Sep 26, 2019

Conversation

dchaykin
Copy link
Collaborator

scripts/signer is not removed yet for compatibility reasons

MMulthaupt
MMulthaupt requested changes Sep 26, 2019
View reviewed changes
Copy link
Collaborator

@MMulthaupt MMulthaupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix failing test at minimum.

cmd/signer/main.go Outdated Show resolved Hide resolved
cmd/signer/main_test.go Show resolved Hide resolved
cmd/signer/main_test.go Show resolved Hide resolved
cmd/signer/main_test.go Show resolved Hide resolved
@MMulthaupt MMulthaupt merged commit d796908 into develop Sep 26, 2019
@MMulthaupt MMulthaupt deleted the feature-signer branch September 26, 2019 13:24
@MMulthaupt MMulthaupt mentioned this pull request Sep 30, 2019
Closed
@dragetd dragetd mentioned this pull request Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMulthaupt MMulthaupt MMulthaupt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dchaykin @MMulthaupt