feat: replace forward pass with decision tree #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elaboration into 3D of the Wu et al 2005 paper Wu, Otoo, and Suzuki. "Two Strategies to Speed up Connected Component Labeling Algorithms". 2005. LBNL-59102. https://crd-legacy.lbl.gov/~kewu/ps/LBNL-59102.html
Everything at Z = -1 needs to account for items at Z = 0 Voxel H doesn't account for D,E,F,J
Also, we need to test F regardless of D and J
|
Still a random segfault hiding in there somewhere... Also, eyeballing the output it looks pretty good, but the number of segments is different compared to master. |
Names of voxels changed, and removed one
|
In time trials, so far it looks like on a particular 512 cube, the old code takes about 7 to 8 seconds while this version takes about 3 to 4 seconds. Not bad, provided I can wring the last few issues out of it. |
chore: remove prototype decision tree code
william-silversmith
changed the title
|
Realized that I had been thinking about the problem wrong. 1) The mask needs to essentially cover half the volume. 2) The Z = 0 part is just Kesheng Wu's algorithm, the 3D part is handling Z = -1. This is a very elegant decomposition of the problem. Initial tests of the new decision tree look promising, and somehow it was even faster on the test volume - 2.8 seconds! |
Needs more information and diagrams.
Both locations E and B are fully connected to the upper mask and therefore we do not need to reprocess it.
Each covering should assume the previous first elements are background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elaboration into 3D of the Wu et al 2005 paper
Wu, Otoo, and Suzuki. "Two Strategies to Speed up
Connected Component Labeling Algorithms". 2005. LBNL-59102.
https://crd-legacy.lbl.gov/~kewu/ps/LBNL-59102.html
Resolves #7 and Resolves #9