Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#31 Updated the DSM report plugin to support Java 8 #38

Merged
merged 1 commit into from Mar 18, 2018

Conversation

jimbethancourt
Copy link
Contributor

@jimbethancourt jimbethancourt commented Mar 17, 2018

Issue #31

Updated the DSM plugin to support Java 8 by updating the dtangler dependency and updating the package imports. I have also updated the Java version in the compiler plugin to use Java 8 and take advantage of some of the newer Java features (only minor code changes).

I added the maven-plugin-plugin since the mojo descriptors weren't being generated correctly.

I have successfully tested locally against a Java 8 project.

Will need to be compiled with a Java 8 compiler.

@coveralls
Copy link

coveralls commented Mar 17, 2018

Coverage Status

Coverage increased (+0.3%) to 91.534% when pulling 776dc65 on jimbethancourt:master into aabf6d0 on sevntu-checkstyle:master.

@romani
Copy link
Member

romani commented Mar 18, 2018

https://docs.travis-ci.com/user/languages/java/#Testing-Against-Multiple-JDKs

looks like oraclejdk7 is not on travis anymore.
please remove it from .travis.yml to let CI pass.

@romani
Copy link
Member

romani commented Mar 18, 2018

I tested it on checkstyle project, it works, report is generated.
But looks like there is problem in DSM matric content generation, some cycles I do not see in code, but this is completely different issue.
image
https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/utils/CommonUtils.java
https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/utils/TokenUtils.java

@jimbethancourt , please update travis.yml , squash all commits in one , and I am ready to merge.

@jimbethancourt
Copy link
Contributor Author

Hi @romani,
I have added oraclejdk8 to the Travis build config and removed all other JDKs, and it passed for JDK8, though it looks like it may be using the travis.yml from this repo and won't update until this PR is merged in.

Unfortunately, it looks like I don't have the ability to squash and merge from the pull request since I do not have write permissions in this repository if I am reading https://help.github.com/articles/about-pull-request-merges/ correctly. However, it looks like there are no conflicts and squashing may not be required.

I haven't changed the dtangler algorithm (though I agree it looks like it could use some work).

@romani
Copy link
Member

romani commented Mar 18, 2018

Squash all in your branch , do push to remote with force, GitHub will refresh PR automatically

@jimbethancourt
Copy link
Contributor Author

Commits squashed and force pushed.

@romani romani merged commit c7d8f90 into sevntu-checkstyle:master Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants