OverridableMethodInConstructorCheck_195

sevntu-checkstyle · Sep 1, 2014 · c292c9a · c292c9a
1 parent 02444b4
commit c292c9a
Show file tree

Hide file tree

Showing 27 changed files with 116 additions and 140 deletions.
diff --git a/...a/com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheckTest.java b/...a/com/github/sevntu/checkstyle/checks/coding/OverridableMethodInConstructorCheckTest.java
@@ -296,7 +296,7 @@ public final void testStackOverFlowErrorWithWarning() throws Exception
     {
 
         String[] expected = {
-        	"4:15: " + getCheckMessage(MSG_KEY_LEADS, "doSMTH", mCtorKey, "doPublic"),
+        	"5:15: " + getCheckMessage(MSG_KEY_LEADS, "doSMTH", mCtorKey, "doPublic"),
         	};
 
         verify(checkConfig, getPath("InputOverridableMethodInConstructor22.java"), expected);
@@ -316,7 +316,7 @@ public final void testAbstractMethodCall() throws Exception
     {
 
         String[] expected = {
-        	"18:22: " + getCheckMessage(MSG_KEY, "buildGetter", mCtorKey),
+        	"11:22: " + getCheckMessage(MSG_KEY, "buildGetter", mCtorKey),
         	};
 
         verify(checkConfig, getPath("InputOverridableMethodInConstructor24.java"), expected);

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor10.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor10.java
@@ -1,4 +1,4 @@
-package TestClasses;
+package com.github.sevntu.checkstyle.checks.coding;
 
 import java.io.File;
 import java.io.FileInputStream;
@@ -25,7 +25,7 @@ public static void main(String args[]) throws IOException, ClassNotFoundExceptio
 	}
 
 
-	private class Object1 implements Serializable {
+	private static class Object1 implements Serializable {
 
 		public void readObject(java.io.ObjectInputStream in) throws IOException, ClassNotFoundException {
 			 doSmth(); // no warnings here
@@ -38,7 +38,7 @@ private void doSmth() {
 	}
 
 
-	private static class Object2 extends Object1 implements Serializable {
+	static class Object2 extends Object1 implements Serializable {
 
 		String value;
 
@@ -47,7 +47,6 @@ private void doSmth() {
 			System.out.println("Foo!");
 		}
 
-		//@Override
 		public void readObject(java.io.ObjectInputStream in)throws IOException, ClassNotFoundException {
 			doSmth();
 		}

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor11.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor11.java
@@ -1,4 +1,4 @@
-package TestClasses;
+package com.github.sevntu.checkstyle.checks.coding;
 
 import java.io.File;
 import java.io.FileInputStream;
@@ -25,7 +25,7 @@ public static void main(String args[]) throws IOException, ClassNotFoundExceptio
     }
 
 
-    private class Object1 implements Serializable {
+    private static class Object1 implements Serializable {
 
         public void readObject(java.io.ObjectInputStream in) throws IOException, ClassNotFoundException {
              doSmth(); // a warning here!
@@ -37,7 +37,7 @@ public void doSmth() {
     }
 
 
-    private class Object2 extends Object1 implements Serializable {
+    private static class Object2 extends Object1 implements Serializable {
 
         String value;
 
@@ -46,9 +46,8 @@ public void doSmth() {
             System.out.println(value);
         }
 
-        //@Override
         public void readObject(java.io.ObjectInputStream in)throws IOException, ClassNotFoundException {
-            //doSmth();
+
         }
 
     }

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor12.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor12.java
@@ -1,11 +1,11 @@
+package com.github.sevntu.checkstyle.checks.coding;
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.ObjectInputStream;
 import java.io.ObjectOutputStream;
 import java.io.Serializable;
-
 public class InputOverridableMethodInConstructor12 {
 
 
@@ -23,7 +23,7 @@ public static void main(String args[]) throws IOException, ClassNotFoundExceptio
     }
 
 
-    private class Object1 implements Serializable {
+    private static class Object1 implements Serializable {
 
         public void readObject(java.io.ObjectInputStream in) throws IOException, ClassNotFoundException {
         	 System.out.println("1"); // no warnings here
@@ -35,12 +35,12 @@ public void readObject(java.io.ObjectInputStream in) throws IOException, ClassNo
 
         private static void doSmth() {
             System.out.println("1");
-            doSmth2();
+            Object1.doSmth2();
         }
 
         private static void doSmth2() {
             System.out.println("2");
-            doSmth3();
+            Object1.doSmth3();
         }
 
         public static void doSmth3() {
@@ -53,9 +53,9 @@ public static void println() {
     }
 
 
-    private class Object2 extends Object1 implements Serializable {
+    private static class Object2 extends Object1 implements Serializable {
 
-        static String value;
+        static String value = "";
 
         public static void doSmth3() {
             value = "Foo!";

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor13.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor13.java
@@ -1,4 +1,4 @@
-package TestClasses;
+package com.github.sevntu.checkstyle.checks.coding;
 
 import java.io.File;
 import java.io.FileFilter;
@@ -13,7 +13,7 @@ public static void main(String args[]) throws IOException,
 		(new Object3()).clone();
 	}
 
-	class Object1 implements Cloneable, Data, FileFilter {
+	static class Object1 implements Cloneable, Data, FileFilter {
 
 		public void doSmth() {
 			System.out.println("Bar!");
@@ -40,15 +40,15 @@ final boolean accept2(File pathname) {
 
 	}
 
-	class Object2 extends Object1 implements Data {
+	static class Object2 extends Object1 implements Data {
 		@Override
 		public void doSmth() {
 			System.out.println("Bar!");
 		}
 	}
 
-//                               Object1
-	class Object3 extends Object2 { // implements Serializable 
+
+	static class Object3 extends Object2 { // implements Serializable 
 		private String value;
 
 		@Override

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor14.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor14.java
@@ -1,4 +1,4 @@
-package TestClasses;
+package com.github.sevntu.checkstyle.checks.coding;
 
 import java.io.File;
 import java.io.FileInputStream;
@@ -28,7 +28,7 @@ public static void main(String args[]) throws IOException, ClassNotFoundExceptio
 	}
 
 
-	private class Object1 implements Serializable {
+	private static class Object1 implements Serializable {
 
 		public void readObject(java.io.ObjectInputStream in) throws IOException, ClassNotFoundException {
              doSmth(); // ! a warning here
@@ -40,7 +40,7 @@ public void doSmth() {
 	}
 
 
-	private class Object2 extends Object1 {
+	private static class Object2 extends Object1 {
 
 		String value;
 

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor15.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor15.java
@@ -1,4 +1,4 @@
-package com.puppycrawl.tools.checkstyle.coding;
+package com.github.sevntu.checkstyle.checks.coding;
 
 public class InputOverridableMethodInConstructor15 {
 

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor16.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor16.java
@@ -1,4 +1,4 @@
-package TestClasses;
+package com.github.sevntu.checkstyle.checks.coding;
 
 import java.io.File;
 import java.io.FileInputStream;

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor17.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor17.java
@@ -1,4 +1,4 @@
-package TestClasses;
+package com.github.sevntu.checkstyle.checks.coding;
 
 import java.io.File;
 import java.io.FileInputStream;
@@ -8,7 +8,7 @@
 import java.io.ObjectOutputStream;
 import java.io.Serializable;
 
-public class InputOverridableMethodInConstructor16 {
+public class InputOverridableMethodInConstructor17 {
 
 
 	private class Object1 implements Serializable {

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor18.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor18.java
@@ -1,9 +1,10 @@
+package com.github.sevntu.checkstyle.checks.coding;
 import java.io.IOException;
 import java.io.Serializable;
 
 import com.puppycrawl.tools.checkstyle.gui.Main;
 
-public class InputOverridableMethodInConstructor18 extends WrongClass {
+public class InputOverridableMethodInConstructor18 {
 
 	private class Object1 implements Serializable {
 
@@ -14,6 +15,10 @@ public void readObject(java.io.ObjectInputStream in) throws
 
 		 }
 
+        private void registerColumnType(int i, String string) {
+
+        }
+
 	}
 
 

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor19.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor19.java
@@ -22,28 +22,27 @@
  * Boston, MA  02110-1301  USA
  *
  */
-package org.hibernate.loader;
-
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Iterator;
+package com.github.sevntu.checkstyle.checks.coding;
 
 /**
  * Abstract walker for walkers which begin at an entity (criteria
  * queries and entity loaders).
  *
  * @author Gavin King
  */
-public abstract class InputOverridableMethodInConstructor19 extends JoinWalker {
+public abstract class InputOverridableMethodInConstructor19 {
+
+	private String persister;
+    private Object alias;
 
-	public AbstractEntityJoinWalker(
-			OuterJoinLoadable persister,
-			SessionFactoryImplementor factory,
-			LoadQueryInfluencers loadQueryInfluencers,
+    public InputOverridableMethodInConstructor19(
+			String persister,
+			String factory,
+			String loadQueryInfluencers,
 			String alias) {
-		super( factory, loadQueryInfluencers );
+		super();
 		this.persister = persister;
-		this.alias = ( alias == null ) ? generateRootAlias( persister.getEntityName() ) : alias;
+		this.alias = ( alias == null ) ? persister : alias;
 	}
 
 }
diff --git a/...rces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor2.java b/...rces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor2.java
@@ -1,4 +1,4 @@
-package com.puppycrawl.tools.checkstyle.coding;
+package com.github.sevntu.checkstyle.checks.coding;
 
 public class InputOverridableMethodInConstructor2 {
 

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor20.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor20.java
@@ -1,4 +1,4 @@
-package org.hibernate.bytecode.javassist;
+package com.github.sevntu.checkstyle.checks.coding;
 
 public interface InputOverridableMethodInConstructor20 {
 

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor21.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor21.java
@@ -1,3 +1,4 @@
+package com.github.sevntu.checkstyle.checks.coding;
 public class InputOverridableMethodInConstructor21 {
 
 	public InputOverridableMethodInConstructor21() {

diff --git a/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor22.java b/...ces/com/github/sevntu/checkstyle/checks/coding/InputOverridableMethodInConstructor22.java
@@ -1,3 +1,4 @@
+package com.github.sevntu.checkstyle.checks.coding;
 public class InputOverridableMethodInConstructor22 {
 
 	InputOverridableMethodInConstructor22() {