Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: corrected leading asterisks alignment in javadoc #1035

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Zopsss
Copy link
Contributor

@Zopsss Zopsss commented Mar 25, 2024

Semaphore CI was complaining that some files in the sevntu repository needed to fix their javadoc's leading asterisk alignment based on the new check LeadingAsteriskAlignCheck

@Zopsss Zopsss changed the title corrected leading asterisks alignment in javadoc minor: corrected leading asterisks alignment in javadoc. Mar 25, 2024
@Zopsss
Copy link
Contributor Author

Zopsss commented Mar 25, 2024

@romani I've fixed the PR title as sevntu-checks suggested but I'm not able to understand the other two CI failures

@nrmancuso
Copy link
Contributor

@romani I've fixed the PR title as sevntu-checks suggested but I'm not able to understand the other two CI failures

Please share exact links to failures, failure messages, and what you have tried to do to fix them.

@Zopsss Zopsss changed the title minor: corrected leading asterisks alignment in javadoc. minor: corrected leading asterisks alignment in javadoc Mar 25, 2024
@Zopsss
Copy link
Contributor Author

Zopsss commented Mar 25, 2024

Please share exact links to failures, failure messages, and what you have tried to do to fix them.

The semaphore CI was giving me these two errors:

  1. https://checkstyle.semaphoreci.com/jobs/8c9b91a4-2a3c-401d-99a7-037a149d3db2
    it suggested I need to make a PR at the contribution repo and add the link of it to the description, here is the link of it: add new check: JavadocLeadingAsteriskAlign checkstyle/contribution#848

  2. https://checkstyle.semaphoreci.com/jobs/2733e0a7-c393-4f6c-b684-c8bae37bcc6a#L758
    this error was occurring because there were some classes in this repository which were not following the rule of the new check introduced. I tried to fix them in this PR.

now here 2 CIs are failing:

  1. eclipse-analysis: I'm not able to understand it's error message.
  2. sonarqube: it is giving me this error:-

[ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.11.0.3922:sonar (default-cli) on project sevntu-checks: The plugin [text] does not support Java 11.0.13: org/sonar/plugins/common/TextAndSecretsPlugin has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0 -> [Help 1]

I'm using following java version:

PS C:\Open Source\sevntu.checkstyle> java -version
java version "19.0.1" 2022-10-18
Java(TM) SE Runtime Environment (build 19.0.1+10-21)
Java HotSpot(TM) 64-Bit Server VM (build 19.0.1+10-21, mixed mode, sharing)

@nrmancuso

@nrmancuso
Copy link
Contributor

@Zopsss a good rule of thumb for CI: always compare your PR run to master.

@Zopsss
Copy link
Contributor Author

Zopsss commented Mar 26, 2024

@Zopsss a good rule of thumb for CI: always compare your PR run to master.

can you please elaborate more: comparing PR run to master ?

EDIT: I found a PR, which was about implementing a new check. Do I need to make changes to add support for the new check I implemented as done in the mentioned PR? I'm not so sure what to do

@nrmancuso
Copy link
Contributor

nrmancuso commented Mar 26, 2024

“Compare your PR run to master” means to look at CI in this PR, and look at the CI in master, and compare them.

If the same failure exists, you can assume that the failure is not from your changes.

Copy link
Contributor

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@nrmancuso nrmancuso merged commit 3aa6db2 into sevntu-checkstyle:master Mar 26, 2024
6 of 8 checks passed
@Zopsss Zopsss deleted the new-check branch June 5, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants