Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #140: Updated ForbidCertainImportsCheck #154

Merged
merged 1 commit into from Nov 12, 2013

Conversation

daniilyar
Copy link
Member

Added 'forbiddenImportsExcludesRegexp' parameter to let user exclude some 'forbidden' imports. Example of usage:

  • Package name regexp = ".*ui.*"
  • Forbidden imports regexp = ".*dao.*"
  • Forbidden imports excludes regexp = "^.+Exception$"

@romani
Copy link
Member

romani commented Oct 15, 2013

Daniil, please reconcile what github account you are using with avatar or not.
Please share build in mail-list , smth is wrong in your code, I put few comments on diff-code at github.

@daniilyar
Copy link
Member Author

Done, please review again

@romani
Copy link
Member

romani commented Oct 25, 2013

Please share build in mail-list , smth is wrong in your code.

Please do.

  • private boolean mPackageMatches;
  • private boolean mPackageMatchesGivenRegexp;

I do not like "Given". let switch to mail-list or have a skype call.

@daniilyar
Copy link
Member Author

    private boolean mPackageMatches;
    private boolean mPackageMatchesGivenRegexp;

Fixed

@daniilyar
Copy link
Member Author

@romani
Copy link
Member

romani commented Nov 11, 2013

I am ok with merge, @isopov do you have any comments ?

@isopov
Copy link
Member

isopov commented Nov 12, 2013

Lets merge.

romani added a commit that referenced this pull request Nov 12, 2013
Fixes #140: Updated ForbidCertainImportsCheck
@romani romani merged commit 19b7eb8 into sevntu-checkstyle:master Nov 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants