Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull #905: adds checkstyle verification to eclipsecs-sevntu-plugin #905

Merged
merged 3 commits into from Oct 31, 2022
Merged

Pull #905: adds checkstyle verification to eclipsecs-sevntu-plugin #905

merged 3 commits into from Oct 31, 2022

Conversation

rnveach
Copy link
Contributor

@rnveach rnveach commented Oct 15, 2022 •
edited

@coveralls
Copy link

coveralls commented Oct 15, 2022 •
edited

Coverage Status

Coverage remained the same at 98.798% when pulling f7893f3 on rnveach:test into f10c104 on sevntu-checkstyle:master.

@rnveach
Copy link
Contributor Author

rnveach commented Oct 15, 2022

New line at https://app.travis-ci.com/github/sevntu-checkstyle/sevntu.checkstyle/jobs/585735717#L1553 . No violations.

romani
romani approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge after removal of test commit

@rnveach
Copy link
Contributor Author

rnveach commented Oct 15, 2022

Expected violation is not happening, something is not working.

@rnveach rnveach self-assigned this Oct 15, 2022
@rnveach
Copy link
Contributor Author

rnveach commented Oct 22, 2022

[DEBUG] Added 0 files to process.

We can't use maven plugin because of checkstyle/contribution#273 . Maven doesn't support non-Java files really.

@rnveach rnveach requested a review from romani October 30, 2022 23:14
@rnveach
Copy link
Contributor Author

rnveach commented Oct 30, 2022

@romani This is now resolved. Switching to non-maven for CS run pulled in the files in the project.

This is part of #441 .

@rnveach rnveach assigned romani and unassigned rnveach Oct 30, 2022
@rnveach rnveach changed the title minor: test Pull #905: adds checkstyle verification to eclipsecs-sevntu-plugin Oct 30, 2022
romani
romani approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani merged commit 24deecd into sevntu-checkstyle:master Oct 31, 2022
romani pushed a commit that referenced this pull request Oct 31, 2022
@rnveach @romani
Pull #905: adds checkstyle verification to eclipsecs-sevntu-plugin
220bf2a
romani pushed a commit that referenced this pull request Oct 31, 2022
@rnveach @romani
supplemental: fixed checkstyle violations from #905
69388d9
@rnveach rnveach deleted the test branch October 31, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnveach @coveralls @romani