Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #915: convert maven-checkstyle-plugin to ant #916

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Issue #915: convert maven-checkstyle-plugin to ant #916

merged 2 commits into from
Oct 23, 2022

Conversation

rnveach
Copy link
Contributor

@rnveach rnveach commented Oct 23, 2022

Issue #915

@coveralls

This comment was marked as spam.

Sign in to view
@rnveach
Copy link
Contributor Author

rnveach commented Oct 23, 2022

Output:
https://app.travis-ci.com/github/sevntu-checkstyle/sevntu.checkstyle/jobs/586409021#L859-L871

@rnveach rnveach marked this pull request as ready for review October 23, 2022 01:03
@rnveach rnveach requested a review from romani October 23, 2022 01:04
This was referenced Oct 23, 2022
Merged
Merged
@romani
Copy link
Member

romani commented Oct 23, 2022

sevntu-checks/output.txt

Is not required.

We need to test that it reports violations by extra commit.

@rnveach
Copy link
Contributor Author

rnveach commented Oct 23, 2022

sevntu-checks/output.txt

Removed.

We need to test that it reports violations by extra commit.

Done.

@rnveach
Copy link
Contributor Author

rnveach commented Oct 23, 2022

Failure at https://app.travis-ci.com/github/sevntu-checkstyle/sevntu.checkstyle/jobs/586410408#L873

romani
romani approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani removed their assignment Oct 23, 2022
@rnveach
Copy link
Contributor Author

rnveach commented Oct 23, 2022

Just to note, travis still thinks removing only extra commits is a no-change to it. It failed with removing the extra commit until I did a no-change amend of the previous comment.

@rnveach rnveach mentioned this pull request Oct 23, 2022
Merged
@rnveach rnveach merged commit eb45480 into sevntu-checkstyle:master Oct 23, 2022
@rnveach rnveach deleted the issue_915 branch October 23, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnveach @coveralls @romani