Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: restore features formatting and added remaining suppressions #960

Merged
merged 1 commit into from Dec 9, 2022

Conversation

rnveach
Copy link
Contributor

@rnveach rnveach commented Dec 9, 2022

Issue identified during deployment test.

diff --git a/eclipsecs-sevntu-plugin-feature/feature.xml b/eclipsecs-sevntu-plugin-feature/feature.xml
index 82b90d8..e718a9f 100644
--- a/eclipsecs-sevntu-plugin-feature/feature.xml
+++ b/eclipsecs-sevntu-plugin-feature/feature.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<feature id="com.github.sevntu.checkstyle.checks.feature"
-   label="Extension for eclipse-cs plugin with additional Checks" version="1.44.0">
+<feature id="com.github.sevntu.checkstyle.checks.feature" label="Extension for eclipse-cs plugin with additional Checks" version="1.44.1">
 
    <description url="http://sevntu-checkstyle.github.io/sevntu.checkstyle/">
       http://sevntu-checkstyle.github.io/sevntu.checkstyle/
@@ -17,15 +16,11 @@
    </license>
 
    <url>
-      <discovery label="Sources on GitHub"
-         url="https://github.com/sevntu-checkstyle/sevntu.checkstyle"/>
-      <discovery label="SevNTU checks site"
-         url="http://sevntu-checkstyle.github.io/sevntu.checkstyle/"/>
-      <discovery label="Eclipse Update site"
-         url="http://sevntu-checkstyle.github.io/sevntu.checkstyle/update-site/"/>
+      <discovery label="Sources on GitHub" url="https://github.com/sevntu-checkstyle/sevntu.checkstyle"/>
+      <discovery label="SevNTU checks site" url="http://sevntu-checkstyle.github.io/sevntu.checkstyle/"/>
+      <discovery label="Eclipse Update site" url="http://sevntu-checkstyle.github.io/sevntu.checkstyle/update-site/"/>
    </url>
 
-   <plugin id="eclipsecs-sevntu-plugin" download-size="0" install-size="0" version="1.44.0"
-      unpack="false"/>
+   <plugin id="eclipsecs-sevntu-plugin" download-size="0" install-size="0" version="1.44.1" unpack="false"/>
 
 </feature>

@rnveach
Copy link
Contributor Author

rnveach commented Dec 9, 2022

I am assuming this was not found because travis doesn't run the deploy command mvn -e --no-transfer-progress clean install -f eclipse-pom.xml -Plocal-deploy.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.798% when pulling e795d94 on rnveach:line_formatting_4 into db9e322 on sevntu-checkstyle:master.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@romani
Copy link
Member

romani commented Dec 9, 2022

Strange that I never had this, but ok

@romani romani merged commit 8328c81 into sevntu-checkstyle:master Dec 9, 2022
@rnveach rnveach deleted the line_formatting_4 branch December 9, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants