UI 3 #484
Merged
UI 3 #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
inputremapper/gui/components.py
Outdated
|
|
||
| def _on_preset_changed(self, data: PresetData): | ||
| with HandlerDisabled(self._gui, self._on_gtk_select_preset): | ||
| self._gui.set_active_id(data.name) | ||
| self.show_active_preset(data.name) |
There was a problem hiding this comment.
[mypy] reported by reviewdog 🐶
error: Argument 1 to "show_active_preset" of "PresetSelection" has incompatible type "Optional[str]"; expected "str"
|
tests missing |
|
The preset-buttons on the second page may some day be extended with more information like mapping-count and modification-date. The device and preset pages could support a search bar to filter them
|
|
your new gui code is very nice to work with |
|
|
jonasBoss
reviewed
Oct 15, 2022
|
Here is the diff after the components.py split: https://github.com/sezanzeb/input-remapper/pull/484/files/9b94df472a6ef49b3012ec1fe88d59da651845b4..249255057e0b73acb19b9e8695f789e09f44d977 |
jonasBoss
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #473
will be GTK3 based, because I don't like the theming issues in libadwaita, and because I'd like to save time by continuing to use the GTK version we are using now
migrating to GTK4 might be interesting, because I think then the bottom corners will be rounded as well in gnome