Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce StreamGuard<'a, T> #9

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Introduce StreamGuard<'a, T> #9

merged 1 commit into from
Apr 10, 2017

Conversation

nox
Copy link
Contributor

@nox nox commented Apr 10, 2017

No description provided.

@sfackler
Copy link
Owner

I think it'd probably make more sense to have a method which gives you a guard object around the SslStream itself rather than adding forwarding methods to each thing people care about. I'm imagining something like fn lock(&self) -> StreamGuard<S> where StreamGuard is just a newtype around LockGuard.

@nox nox force-pushed the current-cipher-description branch from d3446bd to 70e1e34 Compare April 10, 2017 22:07
@nox
Copy link
Contributor Author

nox commented Apr 10, 2017

Done.

@nox nox changed the title Introduce SslStream::current_cipher_description Introduce StreamGuard<'a, T> Apr 10, 2017
@sfackler
Copy link
Owner

Thanks!

@sfackler sfackler merged commit 068ebd3 into sfackler:master Apr 10, 2017
@nox nox deleted the current-cipher-description branch April 10, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nox @sfackler