Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose more methods for Asn1Time #687

Open
BenjaminGill-Metaswitch opened this issue Sep 1, 2017 · 3 comments
Open

Expose more methods for Asn1Time #687

BenjaminGill-Metaswitch opened this issue Sep 1, 2017 · 3 comments

Comments

@BenjaminGill-Metaswitch
Copy link

It would be helpful when trying to handle X509 certificates if Asn1Time exposed some method of comparing or converting to a more Rust-y type (e.g. https://docs.rs/chrono/0.4.0/chrono/struct.DateTime.html).
@bossmc
Copy link
Contributor

bossmc commented Sep 1, 2017

Almost certainly needs extensions to the exposed functions through openssl-sys, to be able to manipulate the objects safely.

@sfackler
Copy link
Owner

sfackler commented Sep 1, 2017

There's a PR adding some more functionality that's in progress: #673

@BenjaminGill-Metaswitch
Copy link
Author

OK, thanks - that looks useful. I guess there's a follow-on PR that adds impl From<DateTime> for Asn1Time and impl Into<DateTime> for Asn1Time

breard-r added a commit to breard-r/acmed that referenced this issue Jun 12, 2020
@breard-r
Correctly handle certificate expiration on openssl
a4e0ccf 
The `openssl` crate now include methods to manipulate Asn1Time objects.
Before this improvement, the certificate had to be parsed from the DER
format using the `x509-parser` crate (which is therefore no longer
required).
sfackler/rust-openssl#1173
sfackler/rust-openssl#687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bossmc @sfackler @BenjaminGill-Metaswitch