Add methods for comparing Asn1TimeRef and creating Asn1Time from Unix time #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griff
force-pushed
the
rework-673
branch
2 times, most recently
from
2cf4159
to
d21d51c
Compare
sfackler
reviewed
Oct 13, 2019
sfackler
reviewed
Oct 13, 2019
sfackler
reviewed
Oct 13, 2019
This implements a `diff` method on `Asn1TimeRef` using `ASN1_TIME_diff` and uses this new method to implement combinations of `PartialEq` and `PartialOrd` for `Asn1Time` and `Asn1TimeRef`. This is mostly just a rework of the earlier work done by @illegalprime in his PR sfackler#673 and credit should go to him.
This is mostly just a rework of the earlier work done by @illegalprime in his PR sfackler#673 and credit should go to him.
|
Thanks! |
breard-r
added a commit
to breard-r/acmed
that referenced
this pull request
Jun 12, 2020
The `openssl` crate now include methods to manipulate Asn1Time objects. Before this improvement, the certificate had to be parsed from the DER format using the `x509-parser` crate (which is therefore no longer required). sfackler/rust-openssl#1173 sfackler/rust-openssl#687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a
diffmethod onAsn1TimeRefusingASN1_TIME_diffand uses this new method to implement combinations ofPartialEqandPartialOrdforAsn1TimeandAsn1TimeRef.It also adds a
from_unixmethod toAsn1Timeso that you can create aAsn1Timevalue from atime_tvalue.This is mostly just a rework of the earlier work done by @illegalprime in his PR #673 and credit should go to him.
Solves #1157