Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

235 enforce staysignedin #240

Merged
merged 3 commits into from
May 2, 2017
Merged

235 enforce staysignedin #240

merged 3 commits into from
May 2, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-93.2%) to 5.297% when pulling 10bb751 on 235-enforce-staysignedin into 6cc54c2 on production.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.491% when pulling 6c34cb7 on 235-enforce-staysignedin into 6cc54c2 on production.

@ghost
Copy link
Author

ghost commented Apr 26, 2017

@jszwedko fyi, I wasnt able to use the devise route mappings, as in the controller test files (:create, :destroy, etc) . I did a quick Google search and apparently the devise library isn't compatible with Integration Tests for some reason... so hardcoding the route was the quickest solution. Thanks!

@jszwedko
Copy link
Member

jszwedko commented May 2, 2017

Looks good, thanks for the explanation @jafowler49 !

@jszwedko jszwedko merged commit c0ec6a6 into production May 2, 2017
@jszwedko jszwedko deleted the 235-enforce-staysignedin branch May 2, 2017 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants