Corrected temp resets in dual mode. #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cted spa temp flashing when in dual mode and pool pump off.
… pool pump status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a dual mode device (e.g my RS-2/6 Dual), the Pool temp was being set to TEMP_UNKNOWN on a status message when the spa pump was on. This seems to be from a typo where you meant to say " isSINGLE_DEV_PANEL == true" but did != instead.
Similarly, but not exactly, the Spa temp was being set to TEMP_UNKNOWN on any status message when the Pool pump was off because there was no check to make sure " isSINGLE_DEV_PANEL == true" before setting it to unknown.
I tested these changes on my Dual device and now it works as intended--Spa temp only set to unknown when Spa pump is off, and Pool temp only set to unknown when Pool pump is off. Going through the code logically it seems it will work as intended for single device panels as well.