Text style support

[shikanime]

At the moment all text present in the project is using a default black colour and default Robot font family.

The solution i found is simply add a text style parsing implementation in the SketchStyleParserSerivce.

[shikanime]

My current implementation work https://github.com/sfeir-open-source/xlayers/tree/text-styling.
But I discovered that some demo files (md-components-cards-safari.skecth) display inconsistent colours from the preview and editor using the latest MacOS Sketch until we change the colour and save it again.

[shikanime]

I have problems with the "bplist" parser.
Using a version 43 of sketch file with a single string with simple color, it crashes when it tries to parser a sub-list that is not a "bplist" or "plist" but just a "list".

[shikanime]

I noticed that the "text" class of demo files have different width and color from JSON and from what SketchApp show, after re-editing it everything have real value.
How can the editor find the real color/width with unvalid information in the JSON ? 🤯 🤯

[manekinekko]

Can you elaborate on that more in details ?

[shikanime]

For example in the md-components-cards-safari.sketch:
That happen for all text rect, there is an example:

{
  "frame": {
    "_class": "rect",
    "do_objectID": "137D1F63-2FEE-4720-954E-3684AFDF1CD7",
    "constrainProportions": false,
    "height": 24,
    "width": 241, <--
    "x": 18,
    "y": 137
  }
}

But in fact the color and the width are different:

And after double clicking the any text element, the real color show up (But it doesn't match the preview file color):

When saving the file without any changement the width are fixed in xLayer:

I tried every version from version 50.3 to latest for a couple of demo file, assuming that the original file were around 51.1.
🤯🤯

[manekinekko]

Well, well, that's unfortunate. Maybe a bug in SketchApp? Can we prevent this on our side?

[shikanime]

In fact, this seems difficult to prevent even if we create an exception on the "text" class in the style parser that will break correct files (I still didn't find how they handle the color/width correction).
But if we assume that all demos files could have been corrupted the actual xLayer's style parser work as it should (color and size).

[manekinekko]

Fair enough. We should probably organize the demo files by SketchApp version. This would help us quickly identify corrupted versions. Do you still have the different SketchApp versions on your machine?

[shikanime]

I have all SketchApp version from 46 to 52.

[shikanime]

Btw, as you can see the previously double "text" is also fixed on preview.

That said, I don't know the context of how the demos were created.