Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sferes.create_variants also compiles source file without any definitions #48

Closed
JoostHuizinga opened this issue Oct 11, 2016 · 2 comments
Assignees

Comments

@JoostHuizinga
Copy link
Contributor

This is a difference between old sferes behavior and new sferes behavior. When creating the following wscript file in an experiment:

#! /usr/bin/env python
import sferes

def options(opt): pass

def build(bld):
   uselib_ = 'BOOST EIGEN SDL'
   sferes.create_variants(bld,
                             source = 'maze.cpp',
                             use = 'sferes2 fastsim',
                             target = '',
                             uselib = 'BOOST EIGEN SDL',
                             variants = ['GEN1 POP4'])

My old sferes version compiles maze_gen21_pop4.cpp with GEN1 and POP4 defined. However, the current sferes version also tries to compile maze.cpp, without any defines. This is a problem for my current experimental setup, since many of my 'variant' arguments are mandatory, and maze.cpp does not compile as a result (and maze_gen21_pop4.cpp does not finish compilation either, because maze.cpp fails).

As such, I am curious what the intended behavior is of sferes.create_variants, and what the right way is to deal with this issue. For now, I have removed the statement that causes create_variants to build maze.cpp in my local copy.

@costashatz
Copy link
Collaborator

You are right about that. We need to change it. I will.

@costashatz costashatz self-assigned this Oct 22, 2016
@costashatz
Copy link
Collaborator

Solved in #53 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants