Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for variants #53

Merged
merged 1 commit into from
Oct 23, 2016
Merged

Fix for variants #53

merged 1 commit into from
Oct 23, 2016

Conversation

costashatz
Copy link
Collaborator

Fix for #48 ...

@costashatz
Copy link
Collaborator Author

@JoostHuizinga when you try it and it works, let me know to merge...

@JoostHuizinga
Copy link
Contributor

Works!

@JoostHuizinga
Copy link
Contributor

Minor comment, when compiling, it is no longer clear which variant is being build. For example, when I build my maze experiment with three variants, the compiling phase looks like this:

[12/47] Compiling exp/cmoea/maze.cpp
[13/47] Compiling exp/cmoea/maze.cpp
[14/47] Compiling exp/cmoea/maze.cpp

Though the linking phase shows which variants those were.

[45/47] Linking build/exp/cmoea/maze_dbg_jhdebug_nsga_gen20_pop20
[46/47] Linking build/exp/cmoea/maze_dbg_jhdebug_cmoea_gen20_pop20_div
[47/47] Linking build/exp/cmoea/maze_dbg_jhdebug_nsga_gen20_pop20_div

That said, I am really glad the variants feature no longer creates a separate cpp files for each variant. That got messy really quickly.

@costashatz
Copy link
Collaborator Author

Minor comment, when compiling, it is no longer clear which variant is being build.

Yes this is true, but I haven't really checked how I can display that. In addition, I never really found a reason I would want exactly to see what is compiling. And since it can be seen when linking I think it is not a big issue. So I am merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants