Add BTC executable to pull current BTC->USD rate. Update README accordingly #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling d22dd2d on imkmf:add-btc-executable into * on sferik:master*. |
| @@ -11,6 +11,7 @@ Gem::Specification.new do |spec| | |||
| spec.cert_chain = ['certs/sferik.pem'] | |||
| spec.description = %q{Ruby wrapper for the Mt. Gox Trade API. Mt. Gox allows you to trade US Dollars (USD) for Bitcoins (BTC) or Bitcoins for US Dollars.} | |||
| spec.email = 'sferik@gmail.com' | |||
| spec.executable = 'btc' | |||
There was a problem hiding this comment.
I think you also need to specify:
spec.bindir = 'bin'There was a problem hiding this comment.
Cool. Added in 60ab606.
|
Changes Unknown when pulling 60ab606 on imkmf:add-btc-executable into * on sferik:master*. |
|
Looks good. Thanks! |
sferik
added a commit
that referenced
this pull request
Mar 19, 2013
Add BTC executable to pull current BTC->USD rate. Update README accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm curious if a executable was intentionally left out of the gem – the alias function seems pretty dense when, if you're like me, you're really just looking for a quick way to check the exchange rate.
Let me know if you have any changes you want me to make on my fork – I've tested it locally and it works great! I'll probably keep it around on my local machine as a quick tool regardless!