Replaced global selectors in $ function in rails_admin.dom_ready event h... #1671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that event handlers on
rails_admin.dom_ready
contain code that init jQuery plugins with css selectors like this:$('form [data-...]')
.These handlers are being called when you add new tab in has_many forms. (inside handler for
nested:fieldAdded
).And you don't need to init all plugins in the form. Only the ones that was added.
That's why when I'm passing additional scoping variables to event handlers that help to narrow scope of css selectors.
It affects nested-form and remote-form handlers.
You can use scoping in your custom event handlers for
rails_admin.dom_ready
too.Like this:
I've found another
rails_admin.dom_ready
event handler in ui.js:61, but I'm not sure if it needs to be scoped like this.