Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated help text for trends to match actual amount returned. #338

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

smalleel
Copy link

When running "t --help" or "t help trends", the help text states that it will return 10 trends, but it actually returns 50. I updated the help text accordingly. For bug #337

@smalleel
Copy link
Author

smalleel commented Aug 23, 2016

Weirdly, RuboCop seems to be getting caught on a few issues that weren't effected by this commit.

Offenses:

bin/t:21:1: W: Do not shadow rescued Exceptions
rescue Interrupt ...
^^^^^^^^^^^^^^^^
lib/t/identicon.rb:33:7: C: Use bit.zero? instead of bit == 0.
      bit == 0 ? "\033[48;5;#{@bcolor}m" : "\033[48;5;#{@fcolor}m"
      ^^^^^^^^
lib/t/printable.rb:139:7: C: Use concat instead of push(*).
      lines.push(*Array.new([3 - lines.length, 0].max) { '' })
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/t/rcfile.rb:23:60: C: Use empty? instead of size < 1.
        raise(ArgumentError.new("Username #{username} is #{possibilities.size < 1 ? 'not found.' : 'ambiguous, matching ' + possibilities.join(', ')}"))
                                                           ^^^^^^^^^^^^^^^^^^^^^^
lib/t/rcfile.rb:121:64: C: Use 0o for octal literals.
      File.open(@path, File::RDWR | File::TRUNC | File::CREAT, 0600) do |rcfile|
                                                               ^^^^

33 files inspected, 5 offenses detected
RuboCop failed!

I saw RuboCop was having similar issues with other pull requests as well, for example: #320

Was RuboCop updated at some point and is now upset with some pre-existing items in the source? I see that in the gemfile on line 17 is specifies any version >= 0.37. If the issue is with RuboCop becoming more stringent, would it be okay for me to submit a pull request addressing the issues RuboCop is upset with? Or any insight into what else may be causing this?

@smalleel smalleel closed this Sep 1, 2016
@smalleel smalleel reopened this Sep 1, 2016
@smalleel smalleel closed this Sep 20, 2016
@smalleel smalleel reopened this Sep 20, 2016
@sferik sferik merged commit ed72cd6 into sferik:master Sep 20, 2016
@sferik
Copy link
Owner

sferik commented Sep 20, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants