fix update_with_media

[stve]

This turned out to be easier than I thought it'd be. update_with_media is fairly well tested so I'm not sure additional tests are necessary as these changes are below the surface. I'm happy to add some if you think it's needed.

[stve]

I should also mention mention that i've successfully tested this to verify it works.

[coveralls]

Coverage increased (+0.0%) when pulling a902914 on update_with_media into 88d7b19 on master.

[sferik]

I believe this is already working in master (before your patch). Does this patch fix the issue in the http branch?

[stve]

My mistake, I thought the http branch had been merged, will check and let you know.

[sferik]

The http branch removes the #middleware interface, so it will require a major version bump (6.0.0). Since version 0.5.0 of the http gem is not yet production ready and I plan to push more 5.x releases, I haven’t merged it yet.

I’ve asked @tarcieri to provide a nicer interface (or at least an example) of how to perform a multipart post using the http gem in httprb/http#73.

Also, the HTTP::Response#parse method was temporarily removed, so I’ve hacked it back in, just to make tests pass in the http branch.

You’ll need to update the http dependency in your Gemfile:

gem 'http', :git => 'https://github.com/sferik/http.git', :branch => 'parse'

You may also wish to use my http branch of webmock, which silences deprecation warnings from the HTTP gem at master.

gem 'webmock', :git => 'https://github.com/sferik/webmock.git', :branch => 'http'

[stve]

Thanks! I was just figuring out what versions you were using as pointing at HEAD on http resulted in nearly the entire test suite failing due to HTTP::Response#parse missing as you indicated above.

[justspamjustin]

I am trying to use update_with_media and I'm getting a Missing or Invalid url parameter. error.
I'm opening a file from disk and trying to use update_with_media like this:

file = File.read("./public/uploads/#{image_name}").encode!('UTF-8', 'UTF-8', :invalid => :replace)
@client.update_with_media(post.content, file)

[sferik]

@justspamjustin update_with_media takes a Ruby File object (technically, any IO) as its second argument.

file = File.new("./public/uploads/#{image_name}")
@client.update_with_media(post.content, file)

[justspamjustin]

@sferik Thanks. I'm still a bit new to ruby.

[sferik]

@justspamjustin No problem. In the future, please use the mailing list or Stack Overflow for support questions.

You may also be interested in reviewing the documentation for update_with_media and the example on posting updates.